CI: Configure dependabot to update package.json#1255
Merged
Conversation
|
🍱 You can preview the tagging presets of this pull request here. |
Member
|
This is most likely because dependabot treats iD as an app and the tagging repo as a library:
I think this is generally a sensible choice, because for libraries you want to be more lenient with the exact version that gets resolved in the final application that uses the library (as long as it fits the required minimum version or supported version range). That said, since the tagging-schema only has |
tyrasd
approved these changes
Jun 4, 2025
Member
|
(Sorry, I had forgot to merge this after the review.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was wondering why https://github.com/openstreetmap/id-tagging-schema/pull/1252/files only updates the package-lock.json and not the package.json.
I find it confusing if the one is different, because I consider the package-lock.json something that can be deleted and regenerated.
It looks like https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#versioning-strategy is the config to change this.
This PR adds
which sounds like a good option.
I hope this will make it look more like https://github.com/openstreetmap/id-tagging-schema/pull/1250/files
But I have no experience with this kind of config, so a review is needed :).