Skip to content

CI: Configure dependabot to update package.json#1255

Merged
tyrasd merged 1 commit intomainfrom
tordans-patch-1
Sep 16, 2025
Merged

CI: Configure dependabot to update package.json#1255
tyrasd merged 1 commit intomainfrom
tordans-patch-1

Conversation

@tordans
Copy link
Copy Markdown
Collaborator

@tordans tordans commented Jun 7, 2024

I was wondering why https://github.com/openstreetmap/id-tagging-schema/pull/1252/files only updates the package-lock.json and not the package.json.

I find it confusing if the one is different, because I consider the package-lock.json something that can be deleted and regenerated.

It looks like https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#versioning-strategy is the config to change this.

This PR adds

increase-if-necessary | Leave the constraint if the original constraint allows the new version, otherwise, bump the constraint.

which sounds like a good option.

I hope this will make it look more like https://github.com/openstreetmap/id-tagging-schema/pull/1250/files

But I have no experience with this kind of config, so a review is needed :).

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 7, 2024

🍱 You can preview the tagging presets of this pull request here.

@tyrasd
Copy link
Copy Markdown
Member

tyrasd commented Jun 4, 2025

This is most likely because dependabot treats iD as an app and the tagging repo as a library:

Dependabot default behavior:

  • Try to differentiate between app and library dependencies.
  • For apps, always increase the minimum version requirement to match the new version. The increase strategy.
  • For libraries, widen the allowed version requirements to include both the new and old versions, when possible. The widen strategy.

I think this is generally a sensible choice, because for libraries you want to be more lenient with the exact version that gets resolved in the final application that uses the library (as long as it fits the required minimum version or supported version range).

That said, since the tagging-schema only has devDependencies, this doesn't play a role here, really. So, I think we could set the versioning-strategy to increase or increase-if-necessary as proposed.

@tyrasd tyrasd merged commit 449fae4 into main Sep 16, 2025
@tyrasd
Copy link
Copy Markdown
Member

tyrasd commented Sep 16, 2025

(Sorry, I had forgot to merge this after the review.)

@tyrasd tyrasd deleted the tordans-patch-1 branch September 16, 2025 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants