don't suggest religious=none ?

[k-yle]

i know this is a 3 year old PR, but I'm a bit confused about landuse=religious + religious=none:

I originally thought it was for religions that don't perfectly meet the definition of "religion", or for shared meditation spaces. But actually, the wiki suggests that religious=none is different to all the other values.

So, should we be promoting it as a value here? (landuse=religious | amenity=place_of_worship) + religious=none is only used 167 times. The other 20,000 uses of religious=none are just to indicate that schools etc. are not religious

Originally posted by @k-yle in #263 (comment)

[ak8abhinay]

@k-yle, agree that promoting religion=none for a Religious Area is a logical contradiction that confuses new mappers. So, removing this suggestion from the landuse=religious and amenity=place_of_worship presets helps to prevent these errors in the future. I will raise a PR fixing the JSON and regarding 167 times to fix them is through manually I guess.

[ak8abhinay]

Fixing this issue may involve creating a copy of the religion list of values into a new file. This lets me remove 'Non-religious' from the values shown for religious areas, without affecting the 20,000 schools that still need that option. It is the better way to change the values here without breaking the main file.

[tordans]

It sounds to me we should just not offer this as a translated value anywhere. Mappers can still use it an it will show in the field, just not promoted by the schema which is fine IMO.

[ak8abhinay]

It sounds to me we should just not offer this as a translated value anywhere. Mappers can still use it an it will show in the field, just not promoted by the schema which is fine IMO.

@tordans,
I agree that is a much better way to handle it. I will update the code to stop promoting 'Non-religious' as a suggested value in the main field. This fixes the contradiction without needing an extra file. I'll submit the updated change.

[k-yle]

yeah, this is tricky with the current schema. religious=none makes sense on presets like School, but doesn't make sense on inherently-religious presets like Church or Religious Area.

This might be a wontfix This will not be worked on issue since there's no easy way to support it, and the benefit is quite small. Maybe it's worth waiting for more opinions?

[tyrasd]

no easy way to support it

One possibility would be to leave the existing religion field as is (e.g. for use in the School preset), and create a copy of the field that inherits the strings from the existing field, but limits the options to the values except the none option.¹ This new field can then be used for features like places of worship, etc.

Footnotes

1. In this way the values only need to be translated once and still the o ↩