Add translatable strings for Religion field#263
Conversation
| "benzhu": "Benzhu", | ||
| "buddhist": "Buddhist", | ||
| "caodaism": "Caodaist", | ||
| "chinese_folk": "Chinese Folk", |
There was a problem hiding this comment.
This and “Vietnamese Folk” read a bit awkward. I wonder if the strings should be nouns rather than adjectives; “Chinese Folk Religion” sounds less awkward.
There was a problem hiding this comment.
Chinese Folk Religion seems far better but I am not a native speaker
There was a problem hiding this comment.
Maybe we can make an exception for the particular entries that don’t have a natural adjective form.
tyrasd
left a comment
There was a problem hiding this comment.
I wonder if the strings should be nouns rather than adjectives
My first tendency was also pro nouns instead of adjectives, but I'm also not a native speaker. 🙊
I think what we should do is using the same scheme for this field and the denomination field. Does that change anything for this PR? 🤔
Denomination will be a much more difficult task, because it’s so open-ended. (My past self from 2010 should’ve campaigned hard to make it a freeform text key similar to |
|
@tyrasd Is some extra research/help/review required here? I am not a native speaker but may try recruiting some. (I am interested in denomination stuff as I plan to use it for streetcomplete/StreetComplete#1737 ) |
9d3204d to
49f529e
Compare
|
Upon reflection, I think we should go with the adjective forms of religions, where available. People sometimes need to coin new |
tyrasd
left a comment
There was a problem hiding this comment.
Upon reflection, I think we should go with the adjective forms of religions, where available.
Sorry for the delay in the review of this PR. I'm OK with merging it as is, but I do also agree that "Chinese/Vietnamese Folk" sounds a bit strange. It's also not really the adjective form of the religion as far as I understand. I'd therefore tend to make an exception for these entries, and use the full "* Folk Religion" name of these religions instead. Or what do you think @1ec5 ?
|
i know this is a 3 year old PR, but I'm a bit confused about
I originally thought it was for religions that don't perfectly meet the definition of "religion", or for shared meditation spaces. But actually, the wiki suggests that So, should we be promoting it as a value here? ( |
|
It may be better to make a new issue and just link it here. This comment can be easily forgotten. Not sure is it worth making two separate lists of values? |
|
👍 i wanted to get an opinion from anyone subscribed to this PR first, in case i've just misunderstood something. if there's no comments here i'll open an issue |

Added translatable strings to the Religion field for the most common documented values of the
religionkey. This PR includes each value with at least 100 occurrences and some mention on this wiki page. There are many morereligionvalues in use, but the less common values would likely be more difficult for translators to translate. They’ll still be visible in the dropdown, just not translated yet.Working towards #254.