Add contact:instagram field for POIs

[sbraz]

Hi, I based this on #859, hopefully I got it right :)

[matkoniecz]

Is there some way to get this autodeployed code preview? Why it has not appeared here?

[sbraz]

Let's see if force-pushing helps.

[github-actions]

🍱 You can preview the tagging presets of this pull request here.

[tyrasd]

Hey, thank you for this. It generally looks good to me. Only the field label feels a bit too long. See below for a suggestion to shorten it.

Btw: I had to manually trigger the build, as this is your first PR on this repository. You can now try the changes out on the preview build.

[sbraz]

You can now try the changes out on the preview build.

Thanks and also thanks for the review, I think this push addresses all comments :)

[Hufkratzer]

contact:instagram should additionally be added everywhere where contact:facebook is. e.g. also in leisure=horse_riding. I don't know if there are more such cases.

[sbraz]

Sure, I'm all for horse riding. I didn't see it anywhere else though.

[cuatim]

Hi all :)

@sbraz can I ask about the status of this pull request. I see there is one requested change pending still?

Best,
C

[sbraz]

I addressed @tyrasd's comments long time ago. Can someone please review this again and let me know if something is still missing?

[cuatim]

@tyrasd @matkoniecz @tordans: Anything still needed here? 😅

I also wanted to provide the Test-Documentation here, but the pull request preview link is dead?

Thanks,
C

[matkoniecz]

but the pull request preview link is dead?

I closed, reopened, approved workflow run - preview should be up by the time you look at it

Anything still needed here? 😅

sorry! I am trying to help with backlog (and started when pile had 140 waiting pull requests)

but I am doing it as unpaid hobby and it is limited in a scale, @tyrasd is contracted by OSMF but tagging schema is only small part of iD development. @tordans is AFAIK also doing it as a hobby

I just had session with @tyrasd when we looked at some open PRs, sadly this one was not one of them

sadly I cannot give any promises when I will take look at this specific PR. And while for some time we have weekly sessions for review what I identified as actionable, the next one (23th December) is cancelled due to holidays - and 30th may be too

[sbraz]

The preview works as expected:

[cuatim]

Hi @matkoniecz!

Thanks a lot for the thorough response. I was not aware of the state of the backlog. I assumed (because my PRs were handled quite fast), that maybe something was still missing here.

Some additional testing below. IMHO this PR looks good and is in line with contact:facebook.

Thank you and all others for all the hard work!! 🤗

Links and data

Relevant OSM Wiki links:

• https://wiki.openstreetmap.org/wiki/Key:contact:instagram

Relevant tag usage stats:

• highly used: 232k
• most used social media tag after contact:facebook

Test-Documentation

Preview links & Sidebar Screenshots

https://pr-1019--ideditor-presets-preview.netlify.app/id/dist/#locale=en&disable_features=boundaries&map=19.28/48.20862/16.37398&background=MAPNIK&id=n13065015501

Info-i

[matkoniecz]

though for the record contact: prefix is really silly here

but, well, just because I can approve PR here does not mean that I get to issue deprecations decrees and usage seems sadly clear: https://taghistory.raifer.tech/#***/contact%3Ainstagram/&***/instagram/

and fixing bad contact: prefixes was attempted already and failed

[sbraz]

Hi @matkoniecz, can this be merged as-is? Do I need to do anything else?

[matkoniecz]

For start, thanks for a PR!

And yes, I think it can be merged as is. Though I have no merge right and person merging it may have own comments.

[matkoniecz]

Thanks for the PR! It is now merged but note that before you will see in iD few things need to happen.

iD tagging schema needs to get release (see https://github.com/openstreetmap/id-tagging-schema/releases - latest one mentioned there is just a draft). And later needs to be pulled in by iD.

Thanks again for your contribution! If you are interested in making other one it would be really welcome! Within next weeks I will be quite likely to review incoming PRs much faster than this one waited.