Add contact:facebook field

[Cj-Malone]

It's my first time, please be gentle.

[github-actions]

🍱 Preview the tagging presets of this pull request here: https://pr-859--ideditor-presets-preview.netlify.app/id/dist/#locale=en.

[tyrasd]

Hi. Thanks for your first PR!

See one suggestion below about the label of the field.

In general, I think we can add a field for this tag. 👍
But I'd think we could put a bit of effort into finding out which other presets would also "need" this tag in addition to shops. I would assume that restaurants, hotels and other touristy POIs, as well as the craft and club presets, should also have the field added. It would potentially even a little bit confusing if the field was only available for shop presets, but not these other presets.

[Cj-Malone]

It's a shame there isn't a nice preset category this fits into. For what it's worth StreetComplete ends up with similar issues.

I've added it to some more categories. I expect I'll still have missed some, but time will fix that.

[tyrasd]

looks great, thank you!

I expect I'll still have missed some, but time will fix that.

FYI, I've also added the field to amenity=doctors and amenity=clinic. 😇

[tyrasd]

It's a shame there isn't a nice preset category this fits into.

Agree. What we could do is to create a dummy template preset for POIs whose only purpose is to hold the generic optional fields which should be shared across all "POI" presets, like for example the contact fields. That dummy preset could be referenced by other POI presets by using the cross-reference syntax (e.g. "moreFields": ["{@templates/poi}", …]). That could make maintaining and updating these preset fields much easier in the future.

But that's of course not to be done in this PR.

[Cj-Malone]

Thank you, and yes I strongly agree with some kind of template/category, but I don't know enough this project to talk specifics.

[tyrasd]

fyi: in bdae3f0, I started to introduce a preset template for POIs. In addition, there's now also one basic template preset for "contact fields" and one for the "internet access" fields. This should help to maintain these general fields in the future.

[Cj-Malone]

Awesome, hopefully it makes maintaining a little easier going forward.