Add field for line_arrangement, add presets for power=insulator and power=terminal
#1042
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| { | ||
| "key": "line_arrangement", | ||
| "type": "combo", | ||
| "strings": { | ||
| "options": { | ||
| "horizontal": "Horizontal", | ||
| "semi_horizontal": "Semi Horizontal", | ||
| "vertical": "Vertical", | ||
| "semi_vertical": "Semi Vertical", | ||
| "square": "Square", | ||
| "triangular": "Triangular (scalene)", | ||
| "delta": "Triangular (isosceles)", | ||
| "unarranged": "Unarranged" | ||
| } | ||
| }, | ||
| "label": "Line Arrangement" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,13 @@ | ||
| { | ||
| "key": "line_attachment", | ||
| "type": "combo", | ||
| "strings": { | ||
| "options": { | ||
| "suspension": "Suspension", | ||
| "anchor": "Anchor", | ||
| "pin": "Pin", | ||
| "pulley": "Pulley" | ||
| } | ||
| }, | ||
| "label": "Line Attachment" | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,6 +11,7 @@ | |
| "moreFields": [ | ||
| "colour", | ||
| "manufacturer", | ||
| "line_arrangement", | ||
| "line_management" | ||
| ], | ||
| "geometry": [ | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| { | ||
| "icon": "temaki-power", | ||
| "fields": [ | ||
| "ref", | ||
| "operator", | ||
| "line_attachment" | ||
| ], | ||
| "moreFields": [ | ||
| "height", | ||
| "line_arrangement", | ||
|
Member
There was a problem hiding this comment. FWIW, the combination 🤷
Contributor
There was a problem hiding this comment. Yes but it's a valid combination https://wiki.openstreetmap.org/wiki/File:Power_portal_substation_transition.jpg => |
||
| "line_management" | ||
| ], | ||
| "geometry": [ | ||
| "vertex" | ||
| ], | ||
| "tags": { | ||
| "power": "insulator" | ||
| }, | ||
| "name": "Power Line Insulator" | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,6 +9,7 @@ | |
| "line_attachment" | ||
| ], | ||
| "moreFields": [ | ||
| "line_arrangement", | ||
| "line_management", | ||
| "manufacturer" | ||
| ], | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| { | ||
| "icon": "temaki-power", | ||
| "fields": [ | ||
| "ref", | ||
| "operator" | ||
| ], | ||
| "moreFields": [ | ||
| "height", | ||
| "line_arrangement" | ||
| ], | ||
| "geometry": [ | ||
| "vertex" | ||
| ], | ||
| "tags": { | ||
| "power": "terminal" | ||
| }, | ||
| "addTags": { | ||
| "power": "terminal", | ||
| "line_attachment": "anchor" | ||
| }, | ||
| "name": "Power Line Terminal" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,6 +10,7 @@ | |
| "line_attachment" | ||
| ], | ||
| "moreFields": [ | ||
| "line_arrangement", | ||
| "line_management", | ||
| "manufacturer" | ||
| ], | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we were to go with translatable strings for these tags, I'd prefer if these would be a bit more verbose. I assume these are technical terms, but for a general mapper, they are not particularly helpful – if one must read the wiki to interpret the values, the raw tag values work just as well.
Perhaps something along these lines would work?