Add field for line_arrangement, add presets for power=insulator and power=terminal #1042
Add field for line_arrangement, add presets for power=insulator and power=terminal #1042arch0345 wants to merge 3 commits intoopenstreetmap:mainfrom
line_arrangement, add presets for power=insulator and power=terminal #1042Conversation
|
🍱 Preview the tagging presets of this pull request here: https://pr-1042--ideditor-presets-preview.netlify.app/id/dist/#locale=en. |
arch0345
force-pushed
the
line_arrangement
branch
from
e9d2db9 to
cfd38d4
Compare
tyrasd
added
new-field
tyrasd
changed the title
line_arrangementline_arrangement, add presets for power=insulator and power=terminal
tyrasd
left a comment
tyrasd
left a comment
There was a problem hiding this comment.
Please find some inline comments below.
Generally speaking, I'm struggling a little bit to see the benefit these domain-specific attributes/tags provide in a general purpose OSM editor. Especially when it comes to translatable values there might also be downsides:
- for volunteers translating on transifex (which I assume are typically not trained electrical engineers), it takes valuable time and effort to fully comprehend these tagging schemas and potentially even more time and effort to find proper translations
- it would be easy to introduce a few small mistakes when translating those terms, which could result in a large number of mappers inadvertently choosing wrong tag values
- if the fields were left "raw", it would be implicitly a bit more obvious that one should consult the wiki before mapping these attributes
What do you think?
| "suspension": "Suspension", | ||
| "anchor": "Anchor", | ||
| "pin": "Pin", | ||
| "pulley": "Pulley" |
There was a problem hiding this comment.
If we were to go with translatable strings for these tags, I'd prefer if these would be a bit more verbose. I assume these are technical terms, but for a general mapper, they are not particularly helpful – if one must read the wiki to interpret the values, the raw tag values work just as well.
Perhaps something along these lines would work?
| "suspension": "Suspension", | |
| "anchor": "Anchor", | |
| "pin": "Pin", | |
| "pulley": "Pulley" | |
| "suspension": "Suspended line", | |
| "anchor": "Straight tension sets", | |
| "pin": "Supports underneath the line", | |
| "pulley": "Pulley" |
| "straight": "Straight", | ||
| "branch": "Branch", | ||
| "split": "Split", | ||
| "transpose": "Transpose", | ||
| "cross": "Cross", | ||
| "transition": "Transition", | ||
| "termination": "Termination" |
There was a problem hiding this comment.
see above, perhaps something like this could work:
| "straight": "Straight", | |
| "branch": "Branch", | |
| "split": "Split", | |
| "transpose": "Transpose", | |
| "cross": "Cross", | |
| "transition": "Transition", | |
| "termination": "Termination" | |
| "straight": "Single line continues", | |
| "branch": "Side line branches off", | |
| "split": "Lines split towards different directions", | |
| "transpose": "Line bundles are swapped", | |
| "cross": "Lines cross without connecting", | |
| "transition": "Location changes", | |
| "termination": "Line stops" |
There was a problem hiding this comment.
"straight": "Line continues", no need to have a single line
| ], | ||
| "moreFields": [ | ||
| "height", | ||
| "line_arrangement", |
There was a problem hiding this comment.
FWIW, the combination power=insulator + line_arrangement has (currently) zero uses in OSM: https://overpass-turbo.eu/s/1DGp
🤷
There was a problem hiding this comment.
Yes but it's a valid combination
https://wiki.openstreetmap.org/wiki/File:Power_portal_substation_transition.jpg => horizontal arranged insulator (with a portal mapped as a way)
We may find semi_horizontal suspension portals as well, I don't have picture currently.
Co-authored-by: Martin Raifer <martin@raifer.tech>
Co-authored-by: Martin Raifer <martin@raifer.tech>
do you plan on continuing it or should it be closed as an abandoned PR? |
|
|
|
Don't have any plans on working on this right now |
4 participants
Adds a field for
line_arrangement=*, which was approved back in July. This PR also adds presets forpower=insulatorandpower=terminaland adds translatable options for Line Attachment and Line Management fields