Add power terminal preset

[nlehuby]

Description, Motivation & Context

Add a preset for power terminal

Related issues

Fix #653

Links and data

Relevant OSM Wiki links:

• https://wiki.openstreetmap.org/wiki/Tag%3Apower%3Dterminal
• https://taginfo.openstreetmap.org/tags/power=terminal
• popular unsupported values of major keys #529

[github-actions]

🍱 Your pull request preview is ready

Please use this preview to check your changes. Ideally use the test documentation template and document your test results by commenting on the PR. This will speed up the review process for everyone.

FYI, once this PR is merged, you can use the iD Editor Preview to test your changes in interaction with all other changes.

[nlehuby]

Test-Documentation

Preview links & Sidebar Screenshots

• on vertex
• on point

Search

• using the preset name as search terms

• using terms & aliases as search terms

[tordans]

I don't know a lot about power related data in OSM.
I wonder, though, if this setup which will push users to add the line_attachment=anchor on every note is the best setup, yet. Especially since after clicking the update, the option disappears so I cannot even change it based on the preset or learn more about what I just did.

---

Looking at some data, some other options are in use (globally)

"power=terminal", 67543
"line_attachment=anchor", 6182
"location:transition=yes", 1637
"line_management=transition", 725
"line_attachment=pin", 577
"location=roof", 338
"line_management=termination", 176

Query

% curl -g https://postpass.geofabrik.de/api/0.2/interpreter \
--data-urlencode "options[geojson]=false" \
--data-urlencode "data=
SELECT
  jsonb_object_keys(tags) AS key,
  tags->>jsonb_object_keys(tags) AS value,
  COUNT(*) AS value_count
FROM postpass_point
WHERE tags->>'power' = 'terminal'
GROUP BY key, value
HAVING COUNT(*) > 10
ORDER BY value_count DESC"

---

And we might also want to add a field for source, operator:wikidata and maybe this location:transition?

"power",67543
"line_attachment",6786
"operator",4290
"location:transition",1637
"operator:wikidata",1392
"line_management",1110
"source",784
"location",381
"layer",169
"material",136
"line_arrangement",129
"transformer",127
"operator:wikipedia",108
"brand",94
"brand:wikidata",92
"operator:old",92
"owner",92
"owner:wikidata",92
"note",75
"ref",58
"name",55
"design",47
"endpoint:building",39
"structure",38
"fixme",32
"man_made",32
"source:date",29
"description",25
"voltage",23
"height",21
"highway",20
"cables",16
"support:function",13
"support",13
"mapillary",12
"circuit:endpoint:building",11
"lamp_type",11

Query

curl -g https://postpass.geofabrik.de/api/0.2/interpreter \
--data-urlencode "options[geojson]=false" \
--data-urlencode "data=
SELECT
  jsonb_object_keys(tags) AS key,
  COUNT(*) AS key_count
FROM postpass_point
WHERE tags->>'power' = 'terminal'
GROUP BY key
ORDER BY key_count DESC"

[tordans]

(See comments above to be reviewed)

[nlehuby]

👍 about line_attachment, I've just added it as a field, thanks for the feedback.

But I may need some guidance to take into account your remaining remarks:

• the source field have been removed a few month ago (Remove source field by marking it as a field to be used on changesets (only) #1508), I don't think we want to add it back only for this new preset
• about operator:wikidata, I suppose it would be more relevant to add the most frequent values of operator & operator:wikidata in the nsi, right? From what I can see, there is no management of this attribute here, and it is not common for contributors to fill in this element manually in iD.
• about location:transition, I had also noticed this tag, but there is no documented use on power terminal, either on the terminal page or on the location:transition page, so I don't know how legitimate it is to add it. I think it would be more appropriate to create a dedicated PR for the creation of the field and its addition to all relevant presets by someone with more experience than me on this subject.

[flacombe]

Regarding the tagging to be used in combination with power=terminal, here is some options:

• line_attachment=anchor
• line_management=termination

A termination (more specifically a power=terminal) is at the opposite from a transition, so location:transition is incompatible with power=terminal.

I should add corresponding examples to the wiki to make it clearer

[tordans]

I should add corresponding examples to the wiki to make it clearer

That would be great. Something like tagging examples are always helpful to validate the presets.
What would also be helpful for me are suggestions on how we name those presets (plus icon) in a way that users that are not deep into this schema will understand what to pick.

[flacombe]

I've improved several pages:

• power=terminal (description + examples)
• power=connection (mention line_management)
• line_management=termination (terminal example)

Common principle that should be reminded is power=* are specific concepts and line_management are more transversal and sometimes abstracted concepts. This allows us to adapt to a large diversity of situations.
I hope this helps to complete this PR that is still valid.

[nlehuby]

Any updates on this ? Many of us are waiting for this feature in iD.

[matkoniecz]

will close/reopen to get preview again

[matkoniecz]

I tested it and it works.

But maybe more clear name exists?

Would "Power line termination" be correct and more clear?

[flacombe]

Would "Power line termination" be correct and more clear?

I'm not sure.
In general, power line termination is described with line_management=termination. A power line can terminate even on a pole.

In OSM, a power terminal is more specific for line ending on a building.
Let's say "Power line wall termination"?

[matkoniecz]

Let's say "Power line wall termination"?

at least to me it seems more clear, though I cannot judge is it more accurate

Maybe "Power line reaching building"? "Power line reaches building" ?

[flacombe]

Maybe "Power line reaching building"? "Power line reaches building" ?

Even better indeed

[ZeLonewolf]

I don't understand what a power reaching building is, can someone post a picture?

[flacombe]

It corresponds to the examples on this page: https://wiki.openstreetmap.org/wiki/Tag:power%3Dterminal

[ZeLonewolf]

Electricians call this a service drop. For laymen, "power connection to a building" is probably a good description.

[1ec5]

A service drop is the wire leading to the building. I heard that term even as a layperson in a neighborhood where trees often got in the way of these things. This proposal would tag a service drop as line_management=service_supply. The connection that we tag as power=terminal is apparently called a “weather head” in the utility industry, but I don’t think I’ve ever heard that term as a layperson. There might be alternative terms for it.

For future reference, here’s a glossary of terms that a major American power utility published to help consumers navigate electrical services and permitting.

/ref openstreetmap/iD#11200 (comment)

[flacombe]

The connection that we tag as power=terminal is apparently called a “weather head” in the utility industry

The weather head is one design to achieve a terminal (to avoid rain getting into a vertical pipe open in the wild), particularly for small wires, so as a consequence often for customer connection.

Note that this kind of situation is purely on grid side, so no customer involved (and it's not a weather head).

power=terminal is just not focused on a particular level in grid hierarchy. It can terminate a service line or a grid line independently. line_management=termination is even more general.

[1ec5]

In that case, “power termination point” and “power connection point” might be useful terms, if not more prominent preset names.

[flacombe]

They more relate to line_management=termination and proposed line_management=service_supply tags than power=terminal imho.

Power line reaching building looks like the more accurate for power=terminal

[1ec5]

Power line reaching building looks like the more accurate for power=terminal

“Power line reaching building” would mean a power line that is reaching a building, but this tag is for a node, hence the suggestion for “Power Connection to a Building”. I suggested rewording that as “Power Connection Point” to emphasize that it’s a point feature, because words like “connection” and “hookup” would easily be misunderstood as the line.

[flacombe]

Let's avoid connection word because it's too connoted.
I've got the intent, maybe Power anchor to a building may be good as well, or more generally power anchor on wall is even better.

[matkoniecz]

Please, ping me when power experts digested feedback and adjusted label to optimal

note: mine can be quite confused, both on electricity and on English, though 'tested by newbie' viewpoint should be rock-solid here

[matkoniecz]

not 100% sure are further changes needed - if optimal name is set already please ping me

[matkoniecz]

@nlehuby ping?

[nlehuby]

I think we are good to go with this version.

[matkoniecz]

“Power line reaching building” would mean a power line that is reaching a building, but this tag is for a node, hence the suggestion for “Power Connection to a Building”. I suggested rewording that as “Power Connection Point” to emphasize that it’s a point feature, because words like “connection” and “hookup” would easily be misunderstood as the line.

Would "Where power line is reaching building" be too wordy and/or not an actual English?

[matkoniecz]

As I proposed the current name in #1637 (comment) and there were some protests that it is not optimal I want to ping @k-yle @tordans for an independent review of comments on that.

[matkoniecz]

Looking at this one again: well, from context people will likely see building and power line attached to this node. (hopefully it is not often mapped without building being mapped)

So maybe a bit more cryptic name is not so bad?

(I am getting embarrassed about this one being stuck in a review hell, hopefully it will get out of it soon)

[nlehuby]

I've updated the label as suggested by tyrasd.