Skip to content

Add field for line_arrangement, add presets for power=insulator and power=terminal #1042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
arch0345 wants to merge 3 commits into from
Closed

Add field for line_arrangement, add presets for power=insulator and power=terminal #1042

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cfd38d4
Add field for `line_arrangement`
arch0345 Oct 28, 2023
0852c00
Update data/fields/line_arrangement.json
arch0345 Nov 20, 2023
0dc6d3f
Update data/fields/line_arrangement.json
arch0345 Nov 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions data/fields/line_arrangement.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
{
"key": "line_arrangement",
"type": "combo",
"strings": {
"options": {
"horizontal": "Horizontal",
"semi_horizontal": "Semi Horizontal",
"vertical": "Vertical",
"semi_vertical": "semi-vertical",
Comment thread
arch0345 marked this conversation as resolved.
Outdated
"square": "Square",
"triangular": "Triangular",
"delta": "Delta",
Comment thread
arch0345 marked this conversation as resolved.
Outdated
"unarranged": "Unarranged"
}
},
"label": "Line Arrangement"
}
8 changes: 8 additions & 0 deletions data/fields/line_attachment.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,13 @@
{
"key": "line_attachment",
"type": "combo",
"strings": {
"options": {
"suspension": "Suspension",
"anchor": "Anchor",
"pin": "Pin",
"pulley": "Pulley"
Comment on lines +6 to +9
Copy link
Copy Markdown
Member

@tyrasd tyrasd Nov 20, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we were to go with translatable strings for these tags, I'd prefer if these would be a bit more verbose. I assume these are technical terms, but for a general mapper, they are not particularly helpful – if one must read the wiki to interpret the values, the raw tag values work just as well.

Perhaps something along these lines would work?

Suggested change
"suspension": "Suspension",
"anchor": "Anchor",
"pin": "Pin",
"pulley": "Pulley"
"suspension": "Suspended line",
"anchor": "Straight tension sets",
"pin": "Supports underneath the line",
"pulley": "Pulley"

}
},
"label": "Line Attachment"
}
11 changes: 11 additions & 0 deletions data/fields/line_management.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,17 @@
{
"key": "line_management",
"type": "combo",
"strings": {
"options": {
"straight": "Straight",
"branch": "Branch",
"split": "Split",
"transpose": "Transpose",
"cross": "Cross",
"transition": "Transition",
"termination": "Termination"
Comment on lines +6 to +12
Copy link
Copy Markdown
Member

@tyrasd tyrasd Nov 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see above, perhaps something like this could work:

Suggested change
"straight": "Straight",
"branch": "Branch",
"split": "Split",
"transpose": "Transpose",
"cross": "Cross",
"transition": "Transition",
"termination": "Termination"
"straight": "Single line continues",
"branch": "Side line branches off",
"split": "Lines split towards different directions",
"transpose": "Line bundles are swapped",
"cross": "Lines cross without connecting",
"transition": "Location changes",
"termination": "Line stops"

Copy link
Copy Markdown
Contributor

@flacombe flacombe Nov 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"straight": "Line continues", no need to have a single line

}
},
"label": "Line Management",
"terms": [
"branching",
Expand Down
1 change: 1 addition & 0 deletions data/presets/man_made/utility_pole.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
"moreFields": [
"colour",
"manufacturer",
"line_arrangement",
"line_management"
],
"geometry": [
Expand Down
20 changes: 20 additions & 0 deletions data/presets/power/insulator.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
{
"icon": "temaki-power",
"fields": [
"ref",
"operator",
"line_attachment"
],
"moreFields": [
"height",
"line_arrangement",
Copy link
Copy Markdown
Member

@tyrasd tyrasd Nov 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, the combination power=insulator + line_arrangement has (currently) zero uses in OSM: https://overpass-turbo.eu/s/1DGp

🤷

Copy link
Copy Markdown
Contributor

@flacombe flacombe Nov 20, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes but it's a valid combination

https://wiki.openstreetmap.org/wiki/File:Power_portal_substation_transition.jpg => horizontal arranged insulator (with a portal mapped as a way)
We may find semi_horizontal suspension portals as well, I don't have picture currently.

"line_management"
],
"geometry": [
"vertex"
],
"tags": {
"power": "insulator"
},
"name": "Power Line Insulator"
}
1 change: 1 addition & 0 deletions data/presets/power/pole.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
"line_attachment"
],
"moreFields": [
"line_arrangement",
"line_management",
"manufacturer"
],
Expand Down
22 changes: 22 additions & 0 deletions data/presets/power/terminal.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
{
"icon": "temaki-power",
"fields": [
"ref",
"operator"
],
"moreFields": [
"height",
"line_arrangement"
],
"geometry": [
"vertex"
],
"tags": {
"power": "terminal"
},
"addTags": {
"power": "terminal",
"line_attachment": "anchor"
},
"name": "Power Line Terminal"
}
1 change: 1 addition & 0 deletions data/presets/power/tower.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
"line_attachment"
],
"moreFields": [
"line_arrangement",
"line_management",
"manufacturer"
],
Expand Down
⚡