Add ref and railway:track_ref fields to railway=rail and =switch presets#1083
Add ref and railway:track_ref fields to railway=rail and =switch presets#1083tyrasd merged 12 commits intoopenstreetmap:mainfrom gy-mate:main
ref and railway:track_ref fields to railway=rail and =switch presets#1083Conversation
tordans
left a comment
There was a problem hiding this comment.
LGTM But disclaimer: I know litte about railway-mappging :-).
tyrasd
left a comment
There was a problem hiding this comment.
Apart from a few minor syntax errors (see below), this looks fine for me as well.
Only one question: the ref field seems to be quite a bit more common on railway=rail objects (see taginfo). What was your reasoning behind putting the ref field into moreFields? Are the track numbers usually easier to map?
|
One more suggestion: As switches only have a single reference number, it would be sufficient to use the generic field for the |
Applied suggestions from code review Co-authored-by: Martin Raifer <martin@raifer.tech>
@tyrasd Yeah, @tordans suggested this and I agree with him:
|
|
Ok, that makes sense now. 👍 |
|
🍱 You can preview the tagging presets of this pull request here. |
@tyrasd Well it's not really an essential technical term. You're right, there is no need to overcomplicate, it's still obvious without |
railway=railref=*(Line Number) andrailway:track_ref=*(Track Number) fieldsrailway=switchref=*(Switch Number) field