Conversation
k-yle
added
new-field
|
🍱 Your pull request preview is ready Please use this preview to check your changes. Ideally use the test documentation template and document your test results by commenting on the PR. This will speed up the review process for everyone. FYI, once this PR is merged, you can use the iD Editor Preview to test your changes in interaction with all other changes. |
tordans
added
the
waiting-ready-to-merge
tyrasd
left a comment
tyrasd
left a comment
There was a problem hiding this comment.
In general it looks fine for me.
Some of the new fields use terms that are rather uncommon to non-experts, e.g. "turnout side", but that's fine as the info (i) button is quite helpful.
| "icon": "temaki-freight_car", | ||
| "fields": [ | ||
| "name", | ||
| "railway/ref", |
There was a problem hiding this comment.
PR description mentions adding railway:ref to railway=junction - not railway yard
There was a problem hiding this comment.
sorry i missed this one, PR description updated. 1100 out of 5400 yards have this tag, and the wiki page suggests it.
so i think we can keep this one?
There was a problem hiding this comment.
I am not opposed to it, just got confused when comparing code and description
tyrasd
removed
the
waiting-ready-to-merge
4 participants
Description, Motivation & Context
railway=signalrailway:signal:position=left/right/in_track/bridge/overhead429,000railway=switchrailway:local_operated=yes/no84,000railway:turnout_side=left/right95,000railway=junction+railway=yardrailway:ref=*60,000railway:track_ref=*to all modes of transport. Currently only thetrainpreset has it, nottram/subway/... see Addrefandrailway:track_reffields torailway=railand=switchpresets #1083Related issues
none
Links and data
see above
Relevant tag usage stats:
see above
Test-Documentation
Existing field:
Search
-
Info-
isee screenshots above
Wording
name,aliases(if present) use Title Caseterms(if present) use lower case, sorted A-Z