Add climbing presets + fields #1113
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| { | ||
| "key": "climbing:bolted", | ||
| "type": "check", | ||
| "label": "Bolted" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| { | ||
| "key": "climbing:bolts", | ||
| "type": "number", | ||
| "minValue": 0, | ||
| "label": "Number of Bolts" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| { | ||
| "key": "climbing:grade:french", | ||
| "type": "text", | ||
| "label": "Grade (French)", | ||
| "placeholder": "5c" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| { | ||
| "key": "climbing:grade:saxon", | ||
| "type": "text", | ||
| "label": "Grade (Saxon)", | ||
| "placeholder": "VIIa" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| { | ||
| "key": "climbing:grade:uiaa", | ||
| "type": "text", | ||
| "label": "Grade (UIAA)", | ||
| "placeholder": "6-" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| { | ||
| "key": "climbing:grade:yds_class", | ||
| "type": "text", | ||
| "label": "Grade (YDS)", | ||
| "placeholder": "5.10a" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| { | ||
| "key": "climbing:length", | ||
| "type": "number", | ||
| "minValue": 0, | ||
| "label": "Length (m)" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| { | ||
| "key": "climbing:orientation", | ||
| "type": "combo", | ||
| "label": "Orientation", | ||
| "strings": { | ||
| "options": { | ||
| "N": "North", | ||
| "NE": "North-East", | ||
| "E": "East", | ||
| "SE": "South-East", | ||
| "S": "South", | ||
| "SW": "South-West", | ||
| "W": "West", | ||
| "NW": "North-West" | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| { | ||
| "key": "climbing:quality", | ||
| "type": "combo", | ||
| "options": [ | ||
| "fragile", | ||
| "medium", | ||
| "solid" | ||
| ], | ||
| "label": "Rock Quality" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| { | ||
| "key": "climbing:rock", | ||
| "type": "combo", | ||
| "label": "Rock Type", | ||
| "strings": { | ||
| "options": { | ||
| "limestone": "Limestone", | ||
| "sandstone": "Sandstone", | ||
| "granite": "Granite", | ||
| "quartzite": "Quartzite", | ||
| "gritstone": "Gritstone", | ||
| "gneiss": "Gneiss", | ||
| "porphyry": "Porphyry", | ||
| "basalt": "Basalt", | ||
| "conglomerate": "Conglomerate", | ||
| "slate": "Slate" | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| { | ||
| "key": "climbing:routes", | ||
| "type": "number", | ||
| "minValue": 0, | ||
| "label": "Number of Routes" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| { | ||
| "key": "climbing:summit_log", | ||
| "type": "check", | ||
| "label": "Summit Log", | ||
| "terms": [ | ||
| "route log", | ||
| "summit register" | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| { | ||
| "icon": "temaki-abseiling", | ||
| "geometry": [ | ||
| "point", | ||
| "line", | ||
| "area", | ||
| "relation" | ||
| ], | ||
| "fields": [ | ||
| "name" | ||
| ], | ||
| "moreFields": [ | ||
| "climbing/length", | ||
|
Member
There was a problem hiding this comment. Does it really make sense to specify the length of a climbing crag? Is it the sum of the routes on it? What practical use would such a number have?
Contributor
Author
There was a problem hiding this comment. The Often the crag has almost all routes with the same lenght, but usually there are few shorter routes, or perhaps one longer. So this value on the crag works as a default for all the routes, but each route can overwrite it. Of course, if each route is different length, the it probably wouldn't make sense to tag it on |
||
| "climbing/routes", | ||
| "climbing/bolted", | ||
| "climbing/orientation", | ||
| "climbing/quality", | ||
| "climbing/rock", | ||
| "website", | ||
| "ele" | ||
| ], | ||
| "terms": [ | ||
| "rock climbing", | ||
| "climbing" | ||
| ], | ||
| "tags": { | ||
| "climbing": "crag" | ||
| }, | ||
| "addTags": { | ||
| "sport": "climbing", | ||
| "climbing": "crag" | ||
| }, | ||
| "name": "Climbing Crag" | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| { | ||
| "icon": "temaki-abseiling", | ||
| "geometry": [ | ||
| "point", | ||
| "line" | ||
| ], | ||
| "fields": [ | ||
| "name", | ||
| "climbing/length", | ||
| "climbing/bolted", | ||
| "climbing/rock" | ||
| ], | ||
| "moreFields": [ | ||
| "climbing/grade/uiaa", | ||
| "climbing/grade/french", | ||
| "climbing/grade/saxon", | ||
| "climbing/grade/yds_class", | ||
| "climbing/bolts", | ||
| "climbing/orientation", | ||
| "climbing/quality", | ||
| "climbing/summit_log", | ||
| "website", | ||
| "ele" | ||
| ], | ||
| "terms": [ | ||
| "rock climbing", | ||
| "climbing" | ||
| ], | ||
| "tags": { | ||
| "climbing": "route" | ||
| }, | ||
| "addTags": { | ||
| "sport": "climbing", | ||
| "climbing": "route" | ||
| }, | ||
| "name": "Climbing Route" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| { | ||
| "icon": "temaki-abseiling", | ||
| "geometry": [ | ||
| "point", | ||
| "vertex" | ||
| ], | ||
| "fields": [ | ||
| "{climbing/route}" | ||
|
Member
There was a problem hiding this comment. I think it does not make sense to just copy-paste the fields from the climbing route preset here. There are quite a few of them which do not make sense (e.g. what is the length of the bottom of a climbing route?), and/or which would just duplicate the property of the respective climbing route object (e.g. the rock type of the route, etc.). Please specify a list of tag which make sense to be used for these features. 🙇 For example,
Contributor
Author
There was a problem hiding this comment. I think the issue here is that Eg. there are 4822 nodes with this tag, and 4575 have name (overpass) which may imply this case. The wiki even specifies this scenario:
Do you think we can leave the "route" fields on the "route_bottoms" then? |
||
| ], | ||
| "moreFields": [ | ||
| "{climbing/route}" | ||
| ], | ||
| "terms": [ | ||
| "rock climbing", | ||
| "climbing" | ||
| ], | ||
| "tags": { | ||
| "climbing": "route_bottom" | ||
| }, | ||
| "addTags": { | ||
| "sport": "climbing", | ||
| "climbing": "route_bottom" | ||
| }, | ||
| "name": "Climbing Route Start" | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| { | ||
| "icon": "temaki-abseiling", | ||
| "geometry": [ | ||
| "point", | ||
| "vertex" | ||
| ], | ||
| "fields": [ | ||
| "{climbing/route}" | ||
| ], | ||
| "moreFields": [ | ||
| "{climbing/route}" | ||
|
Comment on lines
+8
to
+11
|
||
| ], | ||
| "terms": [ | ||
| "rock climbing", | ||
| "climbing" | ||
| ], | ||
| "tags": { | ||
| "climbing": "route_top" | ||
| }, | ||
| "addTags": { | ||
| "sport": "climbing", | ||
| "climbing": "route_top" | ||
| }, | ||
| "name": "Climbing Route Top" | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.