Conversation
|
Everything should have sport=climbing, no? |
|
Thanks @endolith, very good point. I added the |
|
Thanks for the feedback, @endolith 🙂 ad grades) unfortunately tagging allows for different marks to be assigned for different grade systems. So we have to add a field for each of them in iD. I added the YDS, but in future it would perhaps make sense to create a custom iD field type (like type=multi), which would have better UX (user is not supposed to fill in all of them). ad "It complains about some points being on trails or cliffs") Good point. I added ad "But not others") I didn't create a preset for route_top for start, but it is easy now. I added the preset. Please check it again in the iD demo, eg Cat in the Hat |
|
🍱 You can preview the tagging presets of this pull request here. |
tyrasd
left a comment
There was a problem hiding this comment.
Hi. Thanks for this comprehensive pull request. It looks already quite good. Please find some inline comments, questions and suggestions for some details below.
And as a general remark, the label property of fields and the name of the presets should follow the so called title case spelling. For example: it should be Climbing Route instead of Climbing route. Would you mind adjusting this?
| "name" | ||
| ], | ||
| "moreFields": [ | ||
| "climbing/length", |
There was a problem hiding this comment.
Does it really make sense to specify the length of a climbing crag? Is it the sum of the routes on it? What practical use would such a number have?
There was a problem hiding this comment.
The length in climbing terminology means how long is the route from bottom to top (longer climbs are usually more fun), and this also implies needed rope length.
Often the crag has almost all routes with the same lenght, but usually there are few shorter routes, or perhaps one longer. So this value on the crag works as a default for all the routes, but each route can overwrite it.
Of course, if each route is different length, the it probably wouldn't make sense to tag it on crag as well.
| "vertex" | ||
| ], | ||
| "fields": [ | ||
| "{climbing/route}" |
There was a problem hiding this comment.
I think it does not make sense to just copy-paste the fields from the climbing route preset here. There are quite a few of them which do not make sense (e.g. what is the length of the bottom of a climbing route?), and/or which would just duplicate the property of the respective climbing route object (e.g. the rock type of the route, etc.).
Please specify a list of tag which make sense to be used for these features. 🙇 For example, ele seems to be a reasonably popular one (example).
There was a problem hiding this comment.
I think the issue here is that climbing=route_bottom is very often used as a synonym for "here is the route", and in that case it technically suits as climbing=route.
Eg. there are 4822 nodes with this tag, and 4575 have name (overpass) which may imply this case.
The wiki even specifies this scenario:
Climbing routes can be mapped with a single node marking the bottom of the route, tagged as climbing=route_bottom, or two nodes tagged with climbing=route_bottom and climbing=route_top connected by a way tagged as climbing=route.
Do you think we can leave the "route" fields on the "route_bottoms" then?
| "{climbing/route}" | ||
| ], | ||
| "moreFields": [ | ||
| "{climbing/route}" |
Co-authored-by: Martin Raifer <martin@raifer.tech>
Co-authored-by: Martin Raifer <martin@raifer.tech>
Co-authored-by: Martin Raifer <martin@raifer.tech>
|
@tyrasd Thank you very much for such a good review. Also I am glad I learned how to correctly propose fields, eg. that I should search taginfo first 🙂 Changes deployed to my id instance, eg:
While editing moreFields I also got an idea how to make them more usable: openstreetmap/iD#10181 |
|
Hi @tyrasd - just gently bumping this issue. 🙂 🙏 |
|
I have an update to this PR after one year. 😅 Meanwhile the climbing project got bigger. We have now a running site openclimbing.org which allows easy browsing and creating of climbing features (and uses id-tagging-schema as well). This means, that now we have 14k nodes of I went through this whole PR and it still makes sense, waiting only for two last responses in the @tyrasd's code review (see the unresolved comments in the review above). If we find the answers I think we could move toward merging it and make climbing even better 💪 🙂 I updated the table in PR description with counts, here are only the presets proposed in this PR:
|
|
Closing this huge PR in favor of smaller one: #1590 |





Hi,
I'd love to map more climbing routes according the climbing schema on wiki.
See the discussion in:
This PR
This PR adds the viable minumum to tag climbing crags and climbing routes. I will add more features as needed in future (eg. bouldering, area, alternative tagging for crag and boulder etc).
I add only presets
climbing/cragandclimbing/route+climbing/route_bottomfor start.I built this PR with
distcommand and deployed an iD editor with those presets, so it can be tested thorougly.eg.
.
.
Climbing terminology
The taxonomy goes like this - it can be grouped by relations, or just by nearstanding nodes:
Number of items
sport = climbing
sport = climbing