Skip to content

Add preset for leisure=bathing_place (#1217)#1274

Merged
tordans merged 3 commits intoopenstreetmap:mainfrom
osmuser63783:main
Jul 8, 2024
Merged

Add preset for leisure=bathing_place (#1217)#1274
tordans merged 3 commits intoopenstreetmap:mainfrom
osmuser63783:main

Conversation

@osmuser63783
Copy link
Copy Markdown
Contributor

@osmuser63783 osmuser63783 commented Jun 30, 2024

Description, Motivation & Context

Böhmerheide_-_Badestelle_Landseite
(source)

A bathing place (German: Badestelle, Swedish: badplats) is a designated spot where you can swim or 'bathe'. In Europe these are often signposted by the local authority, as these are the spots where swimming is officially allowed or encouraged, water quality monitored, etc.

The English translation 'bathing place' is a bit awkward but I think the concept of a designated or widely known spot for outdoor swimming is a global one. I have tried to suggest a few synonyms.

leisure=bathing_place has existed for many years as a tag, but bathing places have also been mapped using various other tags that don't really fit e.g. leisure=water_park and I think that's partly because a preset for leisure=bathing_place isn't more widely available.

The tagging scheme does already contain a preset for leisure=swimming_area, for areas only. In a recent community forum discussion it was agreed that leisure=swimming_area is for the part of the water that has been roped off or otherwise clearly designated for swimming, whereas a leisure=bathing_place doesn't usually have a clearly defined boundary so it will usually be mapped as a node. It's a POI - in some languages, people say the equivalent of "let's meet at the bathing place".

Related issues

Closes #1217.

Links and data

Relevant OSM Wiki links:

Relevant tag usage stats:

@Hufkratzer
Copy link
Copy Markdown
Contributor

Shouldn't the preset also be allowed for areas? Some are mapped as an area, e.g. https://www.openstreetmap.org/way/1203484522, https://www.openstreetmap.org/way/56313252

Copy link
Copy Markdown
Collaborator

@tordans tordans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this!

I did a quick review and write down the questions I would like to check out during a proper review. Maybe someone can help with answers.

It would also be great to have a few screenshots on the search so we can see that there are no weird results where users would now pick a wrong answer due to the new preset.

Comment thread data/presets/leisure/bathing_place.json Outdated
Comment thread data/presets/leisure/bathing_place.json Outdated
"Swimming spot",
"Wild swimming spot"
],
"icon": "fas-water-ladder",
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"ladder" does not sound ideal for a place that is often unofficial and will likely not have a ladder. What would be other options?

Do we use ladder for other presets as well? (Might this cause confusion?)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! So

  • public_bath uses maki-water which is just a drop of water, and the same icon is used by a lot of other water-related features e.g. lake and spring, so probably a poor choice
  • beach_resort uses fas-umbrella-beach which is probably worse because it doesn't even show water
  • swimming_area uses fas-swimmer which I can't find on the FAS website but looks identical to person-swimming
  • I suggested fas-water-ladder because I was under the impression that it was not used in this project (the search didn't return anything) but I have since realised that it's actually being used in the swimming pool preset where it's called fas-swimming-pool!

Comment thread data/presets/leisure/bathing_place.json Outdated
Comment thread data/presets/leisure/bathing_place.json
Comment thread data/presets/leisure/bathing_place.json Outdated
Comment on lines +20 to +26
"opening_hours",
"operator",
"fee",
"payment_multi_fee",
"charge_fee",
"supervised",
"lifeguard_check",
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this tag used for kind of official places as well? Or do they become something else once they are paid and supervised?

Copy link
Copy Markdown
Contributor Author

@osmuser63783 osmuser63783 Jul 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would normally make it an amenity=public_bath or possibly a leisure=beach_resort. So although a few dozen bathing_places have fee, opening_hours, supervised and/or lifeguard tags, the answer (key) is almost always no and 24/7. That's why I put it in moreFields, not in fields. But I am not very familiar with the conventions of id-tagging-schema - let me know if this means that, for example, it should not be in the preset at all.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think about it this way…

  • add fields/moreFields that are already used a lot in the data
  • add fields/moreFields that are very helpful to have and documented/"in use"
  • don't add fields/moreFields that we don't want new Users to add

So in this case the question seems to be if we want to give visibility to data that is present but maybe wrong because it should be a different primary tag. I think we should not add those fields. Experienced users will see the data regardless. But less experienced users will not add "false" data. Experienced users can change the preset and then the data will be visible.

@osmuser63783

This comment was marked as resolved.

@tordans

This comment was marked as outdated.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 2, 2024

🍱 You can preview the tagging presets of this pull request here.

@osmuser63783
Copy link
Copy Markdown
Contributor Author

I’ve added the informal field, removed the moreFields, added area as possible geometry and used Camel Case for the aliases and name.

This leaves the icon. I can’t find a better one among the existing icon sets I’m afraid but maybe someone else has more luck?

Here are some screenshots.

Screenshot 2024-07-02 at 23 43 46 Screenshot 2024-07-02 at 23 41 32 Screenshot 2024-07-02 at 23 45 32

@tordans
Copy link
Copy Markdown
Collaborator

tordans commented Jul 6, 2024

Thanks @osmuser63783 for the update.

On the topic of the Icon: How about this for a quick fix…

  1. We change https://github.com/openstreetmap/id-tagging-schema/blob/main/data/presets/amenity/public_bath.json#L2 to the Ladder+Water Icon you use now
    Reading the wiki this is a good fit, because there will likely be some kind of formal facility (and a ladder)

  2. We then use the water drop for the new preset "Bathing Place".
    Usually I would say this icon is not good for bathing at all… but given the fact that we used it for the other preset for a while now, it seems to work well enough. And the fact that it is more generic / more plain water, fits the more inoffical style of leisure=bathing_place.

Copy link
Copy Markdown
Collaborator

@tordans tordans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Lets switch the icon and then we are good to merge, IMO.

@osmuser63783
Copy link
Copy Markdown
Contributor Author

Thanks, I've swapped the icons!

@tordans
Copy link
Copy Markdown
Collaborator

tordans commented Jul 8, 2024

Thanks for the update @osmuser63783 I think this is ready to be merged, now.


Two things I notices that I wanted to document here:

Wiki defintions: The german wiki page and wikidata entry was different from englisch, in that it said that the tag should only be applied to official and public places. I modified wikidata and added a callout to the wiki page https://wiki.openstreetmap.org/wiki/Tag:leisure%3Dbathing_place . I think it is OK to merge this as is and see if any feedback comes up.

Rendering conflict: The area example from above https://www.openstreetmap.org/way/1203484522 has non-ideal rendering in iD. It does pick the right preset, but the rendering is based on the landuse=grass tag. I would consider this a non ideal tagging, so I think it is not an issue for this ticket.

@tordans tordans merged commit bab09d1 into openstreetmap:main Jul 8, 2024
@osmuser63783
Copy link
Copy Markdown
Contributor Author

Thanks! Yes, the German Wiki hasn't been updated yet following the international discussion that led to the English page looking the way it does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add leisure=bathing_place

3 participants