-
Notifications
You must be signed in to change notification settings - Fork 252
Add preset for leisure=bathing_place (#1217) #1274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| { | ||
| "aliases": [ | ||
| "Bathing Spot", | ||
| "Dip Spot", | ||
| "Dipping Spot", | ||
| "Swim Spot", | ||
| "Swimming Spot", | ||
| "Wild Swimming Spot" | ||
| ], | ||
| "icon": "fas-water-ladder", | ||
|
tordans marked this conversation as resolved.
Outdated
|
||
| "fields": [ | ||
| "name", | ||
| "access_simple", | ||
|
tordans marked this conversation as resolved.
|
||
| "informal", | ||
| "shower", | ||
| "toilets", | ||
| "drinking_water_available", | ||
| "picnic_table" | ||
| ], | ||
| "geometry": [ | ||
| "point", | ||
| "area" | ||
| ], | ||
| "terms": [ | ||
| "bathing", | ||
| "dipping", | ||
| "swimming", | ||
| "swimming hole", | ||
| "ladder", | ||
| "pier", | ||
| "water" | ||
| ], | ||
| "tags": { | ||
| "leisure": "bathing_place" | ||
| }, | ||
| "name": "Bathing Place" | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"ladder" does not sound ideal for a place that is often unofficial and will likely not have a ladder. What would be other options?
Do we use ladder for other presets as well? (Might this cause confusion?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! So
public_bathuses maki-water which is just a drop of water, and the same icon is used by a lot of other water-related features e.g. lake and spring, so probably a poor choicebeach_resortuses fas-umbrella-beach which is probably worse because it doesn't even show waterswimming_areauses fas-swimmer which I can't find on the FAS website but looks identical to person-swimming