Skip to content

Changed information=office name to better distinguish it from visitor_centre#1379

Closed
map-per wants to merge 2 commits intoopenstreetmap:mainfrom
map-per:office
Closed

Changed information=office name to better distinguish it from visitor_centre#1379
map-per wants to merge 2 commits intoopenstreetmap:mainfrom
map-per:office

Conversation

@map-per
Copy link
Copy Markdown
Contributor

@map-per map-per commented Nov 3, 2024

Description, Motivation & Context

Changed the name of the tourism=information + information=office preset to better distinguish between office and visitor_centre. The previous name was misleading.

Related issues

#1369

Relevant OSM Wiki links

Checklist and Test-Documentation Template

Read on to get your PR merged faster…

Follow these steps to test your PR yourself and make it a lot easier and faster for maintainers to check and approve it.

This is how it works:

  1. After you submit your PR, the system will create a preview and comment on your PR:

    🍱 You can preview the tagging presets of this pull request here.
    If this is your first contribution to this project, the preview will not happen right away but requires a click from one of the project members. We will do this ASAP.

  2. Once the preview is ready, use it to test your changes.

  3. Now copy the snippet below into a new comment and fill out the blanks.

  4. Now your PR is ready to be reviewed.

## Test-Documentation

### Preview links & Sidebar Screenshots

<!-- Use the preview to find examples, select the feature in question and **copy this link here**.
     Find examples of nodes/areas. Find examples with a lot of tags or very few tags. – Whatever helps to test this thoroughly.
     Add relevant **screenshots** of the sidebar of those examples. -->

<!-- FYI: What we will check:
     - Is the [icon](https://github.com/ideditor/schema-builder/blob/main/ICONS.md) well chosen.
     - Are the fields well-structured and have good labels.
     - Do the dropdowns (etc.) work well and show helpful data. -->

### Search

<!-- **Test the search** of your preset and share relevant **screenshots** here.
     - Test the preset name as search terms.
     - Also test the preset terms and aliases as search terms (if present). -->

### Info-`i`

<!-- **Test the info-i** for your fields and preset and share relevant **screenshots** here.
     The info needs to help mappers understand the preset and when to use it.
     [Learn more…](https://github.com/openstreetmap/id-tagging-schema/blob/main/CONTRIBUTING.md#info-i)
 -->

### Wording

- [ ] American English
- [ ] `name`, `aliases` (if present) use Title Case
- [ ] `terms` (if present) use lower case, sorted A-Z
<!-- Learn more in https://github.com/openstreetmap/id-tagging-schema/blob/main/GUIDELINES.md#2-design-the-preset -->

@map-per
Copy link
Copy Markdown
Contributor Author

map-per commented Mar 15, 2025

Is there anything I can do to move this PR forward?

@tordans
Copy link
Copy Markdown
Collaborator

tordans commented Mar 15, 2025

Adding the recommended test documentation is a great start. You can find it in the PR template if it is not in the PR description (collapsed).

@map-per
Copy link
Copy Markdown
Contributor Author

map-per commented Mar 18, 2025

But I can't do that because the preview wasn't generated for this PR

@tordans
Copy link
Copy Markdown
Collaborator

tordans commented Mar 18, 2025

But I can't do that because the preview wasn't generated for this PR

That is weird. Usually I see a info on this on the PR which I can click to run the preview action. For this PR I don't see it and even starting the action manually does not help…

Don't know what is going on but it might be faster to create a new PR because those get the link…

@map-per
Copy link
Copy Markdown
Contributor Author

map-per commented Mar 18, 2025

👍 Opened #1485 as a replacement PR

@map-per map-per closed this Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants