Skip to content

fix: Added recycling centre preset separately from container.#1496

Closed
SanaliSLokuge wants to merge 1 commit intoopenstreetmap:mainfrom
SanaliSLokuge:preset-recycling-container
Closed

fix: Added recycling centre preset separately from container.#1496
SanaliSLokuge wants to merge 1 commit intoopenstreetmap:mainfrom
SanaliSLokuge:preset-recycling-container

Conversation

@SanaliSLokuge
Copy link
Copy Markdown

Added a Separate Preset for Recycling Centre inside the centre folder in data\presets\amenity\recycling.

Fixed the issue where recycling center and container had incorrect descriptions:
Recycling center did not have a preset for it instead recycling folder only had a preset for containers. Created a separate preset for Recycling centre and added necessary details.

Related issues

Recycling centre and container have incorrect descriptions #1480

Links and data

Relevant OSM Wiki links:
Link 1
Link 2
Link 3

Added a Separate Preset for Recycling Centre inside the centre folder in data\presets\amenity\recycling.
@Oivo35
Copy link
Copy Markdown

Oivo35 commented Mar 29, 2025

I would keep the current fields of the preset.

    "fields": [
        "name",
        "operator",
        "operator/type",
        "address",
        "building",
        "opening_hours",
        "recycling_accepts"
    ],
    "moreFields": [
        "{@templates/contact}",
        "charge_fee",
        "fee",
        "payment_multi_fee",
        "wheelchair"

centre

The collection_times is used at containers or post boxes and means collection frequency. However, containers and post boxes are mostly accessible 24/7 and this means opening_hours=24/7. Therefore, the recycling center should also have opening_hours instead.

Term waste processing may refer to industrial processing of any waste, see definition. Recycling centre primarilly collects recycable waste.
Waste processing would rather be included under industrial=recycling.

@Oivo35
Copy link
Copy Markdown

Oivo35 commented Mar 29, 2025

@Dimitar5555
Mayby the name should also be changed from Recycling Center (American English) to Recycling Centre (British English).

@Dimitar5555
Copy link
Copy Markdown
Contributor

@Dimitar5555 Mayby the name should also be changed from Recycling Center (American English) to Recycling Centre (British English).

iD's presets use American English by default. There is an en-UK locale where British English is used.

@Dimitar5555
Copy link
Copy Markdown
Contributor

@SanaliSLokuge There are presets for both containers and centers. The issue is caused by their reference tags which I've corrected in #1497.

@tyrasd tyrasd closed this Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants