Add Hot Pot restaurant preset#1569
Conversation
|
🍱 Your pull request preview is ready Please use this preview to check your changes. Ideally use the test documentation template and document your test results by commenting on the PR. This will speed up the review process for everyone. FYI, once this PR is merged, you can use the iD Editor Preview to test your changes in interaction with all other changes. |
Test-DocumentationPreview links & Sidebar ScreenshotsSearchInfo-
|
There was a problem hiding this comment.
Technically this looks good.
I am not sure about the long list of terms, but LLMs say they are OK…
But what I am concered with is that this preset will only target a few results.
Look at https://overpass-turbo.eu/s/25zi (general usage) vs. https://overpass-turbo.eu/s/25zj (what this PR targets).
I suggest to only add the option to the cuisine field but not a separate preset.
But lets see what others think.
Test links
- https://pr-1569--ideditor-presets-preview.netlify.app/id/dist/#locale=en&map=20.00/52.35702/4.89054&disable_features=boundaries&background=Bing&id=n2165936476
- with NSI https://pr-1569--ideditor-presets-preview.netlify.app/id/dist/#locale=en&map=20.00/50.10750/8.66564&disable_features=boundaries&background=Bing&id=n2144172795
- general restaurant https://pr-1569--ideditor-presets-preview.netlify.app/id/dist/#locale=en&map=20.00/48.13588/11.55603&disable_features=boundaries&background=Bing&id=n1713202488
Situation looks less unbalanced in Asia, see https://overpass-turbo.eu/s/268s and https://overpass-turbo.eu/s/268u though I am not really familiar with term. But this may be rare case where we may actually have eurocentrism issue, rejecting it "it is not thing in Europe" seems inappropriate for me. At the same time I am unable to confirm it makes sense. |
|
I assume the label of the preset should be changed to |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
tordans
left a comment
There was a problem hiding this comment.
We can improve this a bit.
Co-authored-by: Tobias <t@tobiasjordans.de>
tyrasd
left a comment
There was a problem hiding this comment.
Approving, although usage is still low, I do know from personal experience that these type of specialized restaurants are actually quite common in some parts of Asia.
the fork-and-knife icon does not fit the preset well. bowl-and-chopsticks is also now perfect, but at least slightly better






Description, Motivation & Context
Hot pots are widely popular in East and Southeast Asia, with types such as Beijing hot pot, Sichuan hot pot, Teochew hot pot, shabu-shabu, sukiyaki and etc. This is a very common POI, but the data is currently low because there is no preset, so not easy to find, adding this preset will help the POI data improve.
This PR also sorts strings of
cuisineaccording to the classification on the wiki and A-Z.Related issues
#1521
Links and data
Relevant OSM Wiki links:
https://wiki.openstreetmap.org/wiki/Key:cuisine
https://wiki.openstreetmap.org/wiki/Tag:cuisine%3Dhotpot
Relevant tag usage stats:
730
Checklist and Test-Documentation Template
Read on to get your PR merged faster…
Follow these steps to test your PR yourself and make it a lot easier and faster for maintainers to check and approve it.
This is how it works:
After you submit your PR, the system will create a preview and comment on your PR:
Once the preview is ready, use it to test your changes.
Now copy the snippet below into a new comment and fill out the blanks.
Now your PR is ready to be reviewed.