Skip to content

Add Hot Pot restaurant preset#1569

Merged
tyrasd merged 7 commits intoopenstreetmap:mainfrom
novolife:restaurant
Nov 18, 2025
Merged

Add Hot Pot restaurant preset#1569
tyrasd merged 7 commits intoopenstreetmap:mainfrom
novolife:restaurant

Conversation

@novolife
Copy link
Copy Markdown
Contributor

Description, Motivation & Context

Hot pots are widely popular in East and Southeast Asia, with types such as Beijing hot pot, Sichuan hot pot, Teochew hot pot, shabu-shabu, sukiyaki and etc. This is a very common POI, but the data is currently low because there is no preset, so not easy to find, adding this preset will help the POI data improve.

This PR also sorts strings of cuisine according to the classification on the wiki and A-Z.

Related issues

#1521

Links and data

Relevant OSM Wiki links:

https://wiki.openstreetmap.org/wiki/Key:cuisine

https://wiki.openstreetmap.org/wiki/Tag:cuisine%3Dhotpot

Relevant tag usage stats:

730

Checklist and Test-Documentation Template

Read on to get your PR merged faster…

Follow these steps to test your PR yourself and make it a lot easier and faster for maintainers to check and approve it.

This is how it works:

  1. After you submit your PR, the system will create a preview and comment on your PR:

    🍱 You can preview the tagging presets of this pull request here.
    If this is your first contribution to this project, the preview will not happen right away but requires a click from one of the project members. We will do this ASAP.

  2. Once the preview is ready, use it to test your changes.

  3. Now copy the snippet below into a new comment and fill out the blanks.

  4. Now your PR is ready to be reviewed.

## Test-Documentation

### Preview links & Sidebar Screenshots

<!-- Use the preview to find examples, select the feature in question and **copy this link here**.
     Find examples of nodes/areas. Find examples with a lot of tags or very few tags. – Whatever helps to test this thoroughly.
     Add relevant **screenshots** of the sidebar of those examples. -->

<!-- FYI: What we will check:
     - Is the [icon](https://github.com/ideditor/schema-builder/blob/main/ICONS.md) well chosen.
     - Are the fields well-structured and have good labels.
     - Do the dropdowns (etc.) work well and show helpful data. -->

### Search

<!-- **Test the search** of your preset and share relevant **screenshots** here.
     - Test the preset name as search terms.
     - Also test the preset terms and aliases as search terms (if present). -->

### Info-`i`

<!-- **Test the info-i** for your fields and preset and share relevant **screenshots** here.
     The info needs to help mappers understand the preset and when to use it.
     [Learn more…](https://github.com/openstreetmap/id-tagging-schema/blob/main/CONTRIBUTING.md#info-i)
 -->

### Wording

- [ ] American English
- [ ] `name`, `aliases` (if present) use Title Case
- [ ] `terms` (if present) use lower case, sorted A-Z
<!-- Learn more in https://github.com/openstreetmap/id-tagging-schema/blob/main/GUIDELINES.md#2-design-the-preset -->

@github-actions
Copy link
Copy Markdown

🍱 Your pull request preview is ready

Please use this preview to check your changes. Ideally use the test documentation template and document your test results by commenting on the PR. This will speed up the review process for everyone.

FYI, once this PR is merged, you can use the iD Editor Preview to test your changes in interaction with all other changes.

@novolife
Copy link
Copy Markdown
Contributor Author

Test-Documentation

Preview links & Sidebar Screenshots

https://pr-1569--ideditor-presets-preview.netlify.app/id/dist/#locale=en&map=17.00/14.65485/121.06466

ss2

ss3

Search

ss1

ss5

Info-i

ss4

Wording

  • American English
  • name, aliases (if present) use Title Case
  • terms (if present) use lower case, sorted A-Z

Comment thread data/fields/cuisine.json Outdated
Comment thread data/fields/cuisine.json Outdated
Comment thread data/fields/cuisine.json
Comment thread data/presets/amenity/restaurant/hotpot.json
@novolife
Copy link
Copy Markdown
Contributor Author

ss4

@novolife novolife requested a review from tordans June 6, 2025 01:35
Copy link
Copy Markdown
Collaborator

@tordans tordans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically this looks good.
I am not sure about the long list of terms, but LLMs say they are OK…

But what I am concered with is that this preset will only target a few results.
Look at https://overpass-turbo.eu/s/25zi (general usage) vs. https://overpass-turbo.eu/s/25zj (what this PR targets).

I suggest to only add the option to the cuisine field but not a separate preset.

But lets see what others think.

Test links

@tordans tordans added new-preset waitfor-discussion a discussion in the osm community (e.g. a tag proposal) is required before this can be worked on labels Jun 6, 2025
@matkoniecz
Copy link
Copy Markdown
Collaborator

Look at https://overpass-turbo.eu/s/25zi (general usage) vs. https://overpass-turbo.eu/s/25zj (what this PR targets).

Situation looks less unbalanced in Asia, see https://overpass-turbo.eu/s/268s and https://overpass-turbo.eu/s/268u

though I am not really familiar with term. But this may be rare case where we may actually have eurocentrism issue, rejecting it "it is not thing in Europe" seems inappropriate for me. At the same time I am unable to confirm it makes sense.

@kjonosm
Copy link
Copy Markdown
Contributor

kjonosm commented Jun 16, 2025

I assume the label of the preset should be changed to Hot Pot Restaurant as Hot Pot describes the actual dish.

@matkoniecz

This comment was marked as resolved.

@tordans

This comment was marked as resolved.

Copy link
Copy Markdown
Collaborator

@tordans tordans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can improve this a bit.

Comment thread data/presets/amenity/restaurant/hotpot.json
Co-authored-by: Tobias <t@tobiasjordans.de>
@novolife novolife requested a review from tordans September 20, 2025 15:08
Copy link
Copy Markdown
Member

@tyrasd tyrasd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, although usage is still low, I do know from personal experience that these type of specialized restaurants are actually quite common in some parts of Asia.

the fork-and-knife icon does not fit the preset well. bowl-and-chopsticks is also now perfect, but at least slightly better
@tyrasd tyrasd merged commit 212ee52 into openstreetmap:main Nov 18, 2025
5 checks passed
@tyrasd tyrasd removed the waitfor-discussion a discussion in the osm community (e.g. a tag proposal) is required before this can be worked on label Nov 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants