Skip to content

remove stile tag when retagging barrier=stile#1624

Merged
tyrasd merged 2 commits intoopenstreetmap:mainfrom
matkoniecz:matkoniecz-patch-1
Nov 18, 2025
Merged

remove stile tag when retagging barrier=stile#1624
tyrasd merged 2 commits intoopenstreetmap:mainfrom
matkoniecz:matkoniecz-patch-1

Conversation

@matkoniecz
Copy link
Copy Markdown
Collaborator

it will stop trail of debris happening when people retag stiles to gates

Description, Motivation & Context

fixes openstreetmap/iD#11175

Related issues

fixes openstreetmap/iD#11175

Links and data

Relevant OSM Wiki links:

Relevant tag usage stats:

Checklist and Test-Documentation Template

Read on to get your PR merged faster…

Follow these steps to test your PR yourself and make it a lot easier and faster for maintainers to check and approve it.

This is how it works:

  1. After you submit your PR, the system will create a preview and comment on your PR:

    🍱 Your pull request preview is ready.
    If this is your first contribution to this project, the preview will not happen right away but requires a click from one of the project members. We will do this ASAP.

  2. Once the preview is ready, use it to test your changes.

  3. Now copy the snippet below into a new comment and fill out the blanks.

  4. Now your PR is ready to be reviewed.

## Test-Documentation

### Preview links & Sidebar Screenshots

<!-- Use the preview to find examples, select the feature in question and **copy this link here**.
     Find examples of nodes/areas. Find examples with a lot of tags or very few tags. – Whatever helps to test this thoroughly.
     Add relevant **screenshots** of the sidebar of those examples. -->

<!-- FYI: What we will check:
     - Is the [icon](https://github.com/ideditor/schema-builder/blob/main/ICONS.md) well chosen.
     - Are the fields well-structured and have good labels.
     - Do the dropdowns (etc.) work well and show helpful data. -->

### Search

<!-- **Test the search** of your preset and share relevant **screenshots** here.
     - Test the preset name as search terms.
     - Also test the preset terms and aliases as search terms (if present). -->

### Info-`i`

<!-- **Test the info-i** for your fields and preset and share relevant **screenshots** here.
     The info needs to help mappers understand the preset and when to use it.
     [Learn more…](https://github.com/openstreetmap/id-tagging-schema/blob/main/CONTRIBUTING.md#info-i)
 -->

### Wording

- [ ] American English
- [ ] `name`, `aliases` (if present) use Title Case
- [ ] `terms` (if present) use lower case, sorted A-Z
<!-- Learn more in https://github.com/openstreetmap/id-tagging-schema/blob/main/GUIDELINES.md#2-design-the-preset -->

it will stop trail of debris happening when people retag stiles to gates
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 2, 2025

🍱 Your pull request preview is ready

Please use this preview to check your changes. Ideally use the test documentation template and document your test results by commenting on the PR. This will speed up the review process for everyone.

FYI, once this PR is merged, you can use the iD Editor Preview to test your changes in interaction with all other changes.

@matkoniecz
Copy link
Copy Markdown
Collaborator Author

matkoniecz commented Jul 8, 2025

not sure is it fault of this PR but I no longer see stiles in edit mode

see say https://www.openstreetmap.org/edit?editor=id&node=3127481395#map=21/51.4908271/0.2093590

https://www.openstreetmap.org/node/3127481386

screen-2025-07-08-10-23-28
screen-2025-07-08-10-23-21

in comparison with released id

@k-yle
Copy link
Copy Markdown
Collaborator

k-yle commented Jul 23, 2025

see also: #1622 (comment) for discussion about a more generic solution

@matkoniecz
Copy link
Copy Markdown
Collaborator Author

Comment thread data/presets/barrier/stile.json Outdated
"removeTags": {
"barrier": "stile",
"stile": "*",
"material": "*"
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in my testing material was for some reason not removed

no idea why

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the material tag is preserved when the new preset (e.g. barrier=gate) also has the material field. This is as intended. :)

@tyrasd tyrasd changed the title remove stile and material when retagging stile remove stile tag when retagging barrier=stile Nov 18, 2025
@tyrasd tyrasd merged commit 54e1086 into openstreetmap:main Nov 18, 2025
5 checks passed
@tyrasd tyrasd added the preset label Nov 18, 2025
@matkoniecz
Copy link
Copy Markdown
Collaborator Author

at least material is seen in gate presets so has greater chance to be fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

retagging stile leaves stile= tag behind

3 participants