Add Ceremonial Gate and related presets#1693
Conversation
|
🍱 Your pull request preview is ready Please use this preview to check your changes. Ideally use the test documentation template and document your test results by commenting on the PR. This will speed up the review process for everyone. FYI, once this PR is merged, you can use the iD Editor Preview to test your changes in interaction with all other changes. |
|
If |
I have learned from the proposer that he will initiate a mass replacement process in recent. The deprecation notice here is to prevent anyone unaware of the recent proposal from continuing to use the old tag. |
|
OK, then I will wait with own proposal for bot edit covering this. EDIT: https://community.openstreetmap.org/t/mechanical-edit-proposal-of-man-made-ceremonial-gate/135000/ |
I have finished the mechanical edit. So I think it's time to add ceremonial gate to presets. |
tordans
left a comment
There was a problem hiding this comment.
This looks good but I think we should consider this one change as an improvement.
| "colour", | ||
| "lit" | ||
| "{man_made/ceremonial_gate}", | ||
| "colour" |
There was a problem hiding this comment.
So colour is only relevant here? Just curious of to why…
Co-authored-by: Tobias <t@tobiasjordans.de>
Co-authored-by: Tobias <t@tobiasjordans.de>
| "tags": { | ||
| "man_made": "ceremonial_gate" | ||
| }, | ||
| "name": "Ceremonial Gate" |
There was a problem hiding this comment.
Note to self: I was considering if this should be "Ceremonial Gate (unspecified)" (related to #1706) but the example table at https://wiki.openstreetmap.org/wiki/Tag:man_made%3Dceremonial_gate suggest that this there is no specific tagging for other gate types, yet so they should just have this generic name, I think.
|
Possible follow ups:
But both topics need some more research and are relevant for the iD repo only.
|
|
Thanks for moving this along! It was great to see the discussion and work switch from here to the forum … to a proposal … to a mechanical edit … and back here. 👍 |













Description, Motivation & Context
The Proposal of tag
man_made=ceremonial_gatehas been approved, and the former Torii preset need to be updated to the current tag combination. Also introduced Ceremonial Gate field and preset, and Paifang preset.Related PR
#1214
#1565
Links and data
Relevant OSM Wiki links:
Relevant tag usage stats:
man_made=torii: 10455man_made=paifang: 659man_made=hongsalmun: 40man_made=iljumun: 5Checklist and Test-Documentation Template
Read on to get your PR merged faster…
Follow these steps to test your PR yourself and make it a lot easier and faster for maintainers to check and approve it.
This is how it works:
After you submit your PR, the system will create a preview and comment on your PR:
Once the preview is ready, use it to test your changes.
Now copy the snippet below into a new comment and fill out the blanks.
Now your PR is ready to be reviewed.