Skip to content

Add Ceremonial Gate and related presets#1693

Merged
tordans merged 16 commits intoopenstreetmap:mainfrom
novolife:gates
Sep 9, 2025
Merged

Add Ceremonial Gate and related presets#1693
tordans merged 16 commits intoopenstreetmap:mainfrom
novolife:gates

Conversation

@novolife
Copy link
Copy Markdown
Contributor

Description, Motivation & Context

The Proposal of tag man_made=ceremonial_gate has been approved, and the former Torii preset need to be updated to the current tag combination. Also introduced Ceremonial Gate field and preset, and Paifang preset.

Related PR

#1214

#1565

Links and data

Relevant OSM Wiki links:

Relevant tag usage stats:

  • man_made=torii: 10455
  • man_made=paifang: 659
  • man_made=hongsalmun: 40
  • man_made=iljumun: 5

Checklist and Test-Documentation Template

Read on to get your PR merged faster…

Follow these steps to test your PR yourself and make it a lot easier and faster for maintainers to check and approve it.

This is how it works:

  1. After you submit your PR, the system will create a preview and comment on your PR:

    🍱 Your pull request preview is ready.
    If this is your first contribution to this project, the preview will not happen right away but requires a click from one of the project members. We will do this ASAP.

  2. Once the preview is ready, use it to test your changes.

  3. Now copy the snippet below into a new comment and fill out the blanks.

  4. Now your PR is ready to be reviewed.

## Test-Documentation

### Preview links & Sidebar Screenshots

<!-- Use the preview to find examples, select the feature in question and **copy this link here**.
     Find examples of nodes/areas. Find examples with a lot of tags or very few tags. – Whatever helps to test this thoroughly.
     Add relevant **screenshots** of the sidebar of those examples. -->

<!-- FYI: What we will check:
     - Is the [icon](https://github.com/ideditor/schema-builder/blob/main/ICONS.md) well chosen.
     - Are the fields well-structured and have good labels.
     - Do the dropdowns (etc.) work well and show helpful data. -->

### Search

<!-- **Test the search** of your preset and share relevant **screenshots** here.
     - Test the preset name as search terms.
     - Also test the preset terms and aliases as search terms (if present). -->

### Info-`i`

<!-- **Test the info-i** for your fields and preset and share relevant **screenshots** here.
     The info needs to help mappers understand the preset and when to use it.
     [Learn more…](https://github.com/openstreetmap/id-tagging-schema/blob/main/CONTRIBUTING.md#info-i)
 -->

### Wording

- [ ] American English
- [ ] `name`, `aliases` (if present) use Title Case
- [ ] `terms` (if present) use lower case, sorted A-Z
<!-- Learn more in https://github.com/openstreetmap/id-tagging-schema/blob/main/GUIDELINES.md#2-design-the-preset -->

@github-actions
Copy link
Copy Markdown

🍱 Your pull request preview is ready

Please use this preview to check your changes. Ideally use the test documentation template and document your test results by commenting on the PR. This will speed up the review process for everyone.

FYI, once this PR is merged, you can use the iD Editor Preview to test your changes in interaction with all other changes.

@novolife
Copy link
Copy Markdown
Contributor Author

@matkoniecz
Copy link
Copy Markdown
Collaborator

If man_made=torii and man_made=paifang would benefit from mass replace - maybe we can do this with a discussed bot edit rather than expecting people to do undiscussed manual distributed bot edit?

@novolife
Copy link
Copy Markdown
Contributor Author

If man_made=torii and man_made=paifang would benefit from mass replace

I have learned from the proposer that he will initiate a mass replacement process in recent. The deprecation notice here is to prevent anyone unaware of the recent proposal from continuing to use the old tag.

@matkoniecz
Copy link
Copy Markdown
Collaborator

matkoniecz commented Aug 30, 2025

OK, then I will wait with own proposal for bot edit covering this.

EDIT: https://community.openstreetmap.org/t/mechanical-edit-proposal-of-man-made-ceremonial-gate/135000/

@daishu0000
Copy link
Copy Markdown

OK, then I will wait with own proposal for bot edit covering this.

EDIT: https://community.openstreetmap.org/t/mechanical-edit-proposal-of-man-made-ceremonial-gate/135000/

I have finished the mechanical edit. So I think it's time to add ceremonial gate to presets.

Copy link
Copy Markdown
Collaborator

@tordans tordans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good but I think we should consider this one change as an improvement.

Comment thread data/presets/man_made/ceremonial_gate/paifang.json
"colour",
"lit"
"{man_made/ceremonial_gate}",
"colour"
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So colour is only relevant here? Just curious of to why…

Comment thread data/presets/man_made/ceremonial_gate/torii.json
novolife and others added 3 commits September 4, 2025 15:17
Co-authored-by: Tobias <t@tobiasjordans.de>
Co-authored-by: Tobias <t@tobiasjordans.de>
"tags": {
"man_made": "ceremonial_gate"
},
"name": "Ceremonial Gate"
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to self: I was considering if this should be "Ceremonial Gate (unspecified)" (related to #1706) but the example table at https://wiki.openstreetmap.org/wiki/Tag:man_made%3Dceremonial_gate suggest that this there is no specific tagging for other gate types, yet so they should just have this generic name, I think.

@tordans
Copy link
Copy Markdown
Collaborator

tordans commented Sep 9, 2025

Possible follow ups:

  1. Should those gates when mapped as line always be connected to the way? Otherwise data consumers cannot see them as a barrier (which they are in terms of height / width).
  2. Ideally we would have some styling for the gates in iD. Right now we use the default line style.

But both topics need some more research and are relevant for the iD repo only.

image https://pr-1693--ideditor-presets-preview.netlify.app/id/dist/#locale=en&map=21.40/35.69651/139.77407&disable_features=boundaries&background=Bing&id=w1189794111

@tordans tordans merged commit 6200801 into openstreetmap:main Sep 9, 2025
5 checks passed
@tordans
Copy link
Copy Markdown
Collaborator

tordans commented Sep 9, 2025

Thanks for moving this along! It was great to see the discussion and work switch from here to the forum … to a proposal … to a mechanical edit … and back here. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants