-
Notifications
You must be signed in to change notification settings - Fork 252
Add Ceremonial Gate and related presets #1693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 13 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
33ac3e4
Create ceremonial_gate.json
novolife 6b2e40d
decrecate torii and paifang
novolife 1952592
Create ceremonial gate preset
novolife 1156318
Update torii preset
novolife c8f67d0
Create paifang preset
novolife 3c8511c
fix paifang geometry
novolife 1057bd8
Update paifang.json
novolife 7ad1034
Update torii.json
novolife cc86d09
Update ceremonial_gate.json
novolife 4d36283
Update torii.json
novolife 431583f
add reference to torii.json
novolife 8eed925
add reference to paifang.json
novolife a70e4e8
fix paifang.json
novolife 1f4d32d
Update paifang.json
novolife 66b981b
Update torii.json
novolife c147d24
fix torii.json
novolife File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| { | ||
| "key": "ceremonial_gate", | ||
| "type": "combo", | ||
| "label": "Type", | ||
| "strings": { | ||
| "options": { | ||
| "torii": "Torii", | ||
| "paifang": "Paifang", | ||
| "hongsalmun": "Hongsalmun", | ||
| "iljumun": "Iljumun" | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| { | ||
| "icon": "fas-archway", | ||
| "fields": [ | ||
| "ceremonial_gate", | ||
| "height", | ||
| "material", | ||
| "religion" | ||
| ], | ||
| "moreFields": [ | ||
| "name", | ||
| "inscription", | ||
| "operator", | ||
| "access", | ||
| "ref", | ||
| "lit" | ||
| ], | ||
| "geometry": [ | ||
| "point", | ||
| "vertex", | ||
| "line", | ||
| "area" | ||
| ], | ||
| "terms": [ | ||
| "arch", | ||
| "gate", | ||
| "paifang", | ||
| "torii" | ||
| ], | ||
| "tags": { | ||
| "man_made": "ceremonial_gate" | ||
| }, | ||
| "name": "Ceremonial Gate" | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| { | ||
| "icon": "roentgen-city_gate", | ||
| "fields": [ | ||
| "{man_made/ceremonial_gate}" | ||
| ], | ||
| "moreFields": [ | ||
| "{man_made/ceremonial_gate}" | ||
| ], | ||
| "geometry": [ | ||
| "point", | ||
| "vertex", | ||
| "line", | ||
| "area" | ||
| ], | ||
| "terms": [ | ||
| "chinese gate", | ||
| "paifong", | ||
| "pailau", | ||
| "pailou", | ||
| "shanmen" | ||
| ], | ||
| "tags": { | ||
| "man_made": "ceremonial_gate", | ||
| "ceremonial_gate": "paifang" | ||
| }, | ||
|
novolife marked this conversation as resolved.
|
||
| "reference": { | ||
| "key": "ceremonial_gate", | ||
| "value": "paifang" | ||
| }, | ||
| "name": "Paifang" | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,14 +1,11 @@ | ||
| { | ||
| "icon": "temaki-shinto", | ||
| "fields": [ | ||
| "height", | ||
| "material", | ||
| "colour", | ||
| "lit" | ||
| "{man_made/ceremonial_gate}", | ||
| "colour" | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. So |
||
| ], | ||
| "moreFields": [ | ||
| "operator", | ||
| "ref" | ||
| "{man_made/ceremonial_gate}" | ||
| ], | ||
| "geometry": [ | ||
| "point", | ||
|
|
@@ -20,7 +17,12 @@ | |
| "Shinto shrine" | ||
| ], | ||
| "tags": { | ||
| "man_made": "torii" | ||
| "man_made": "ceremonial_gate", | ||
|
novolife marked this conversation as resolved.
|
||
| "ceremonial_gate": "torii" | ||
| }, | ||
| "reference": { | ||
| "key": "ceremonial_gate", | ||
| "value": "torii" | ||
| }, | ||
| "name": "Torii" | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note to self: I was considering if this should be "Ceremonial Gate (unspecified)" (related to #1706) but the example table at https://wiki.openstreetmap.org/wiki/Tag:man_made%3Dceremonial_gate suggest that this there is no specific tagging for other gate types, yet so they should just have this generic name, I think.