Skip to content

More terms #1892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tyrasd merged 7 commits into from
Jan 27, 2026
Merged

More terms #1892

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d23b4ac
Add some new terms to make finding preset entries easier.
matkoniecz Jan 12, 2026
633e555
cheesemonger is not in real modern use
matkoniecz Jan 12, 2026
4473958
drop defunct nouns
matkoniecz Jan 12, 2026
fd3c17c
dropping panorama
matkoniecz Jan 13, 2026
a2e71f8
add more terms
matkoniecz Jan 23, 2026
89bc2ea
Update data/presets/shop/mobile_phone.json
tyrasd Jan 27, 2026
3a5d221
Update data/presets/shop/mobile_phone_accessories.json
tyrasd Jan 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion data/presets/shop/baby_goods.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,10 @@
"tags": {
"shop": "baby_goods"
},
"name": "Baby Goods Store"
"name": "Baby Goods Store",
"terms": [
"infant",
"newborn",
"toddler"
]
}
8 changes: 8 additions & 0 deletions data/presets/shop/fuel.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,13 @@
"shop": "fuel"
},
"name": "Fuel Shop",
Copy link
Copy Markdown
Contributor

@ZeLonewolf ZeLonewolf Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not familiar enough with this type of store to know if these items are typically sold there.

"terms": [
"briquettes",
"coal",
"firewood",
"heating oil",
"kerosene",
"pellets"
],
"matchScore": 0.5
Copy link
Copy Markdown
Contributor

@FloEdelmann FloEdelmann Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this has a match score of 0.5, maybe adding more presets to make it easier to be found is actually counterproductive?

Copy link
Copy Markdown
Collaborator Author

@matkoniecz matkoniecz Jan 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess I can check why it got so low match score

But these terms are quite indicative it is this (what else should match?) so I am fine with it

And at least for this shop I sadly have experience with them (hello from low emission hell, on next day of "better stay indoor and do not open windows" warnings)

Copy link
Copy Markdown
Collaborator Author

@matkoniecz matkoniecz Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low match score is as far as I know to keep gas station higher

}
5 changes: 4 additions & 1 deletion data/presets/shop/mobile_phone.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,8 @@
"tags": {
"shop": "mobile_phone"
},
"name": "Mobile Phone Store"
"name": "Mobile Phone Store",
"terms": [
"smartphone"
Comment thread
tyrasd marked this conversation as resolved.
]
}
3 changes: 2 additions & 1 deletion data/presets/shop/mobile_phone_accessories.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@
"shop": "mobile_phone_accessories"
},
"terms": [
"phone case"
"phone case",
Comment thread
tyrasd marked this conversation as resolved.
"smartphone"
],
"name": "Mobile Phone Accessory Store"
}
5 changes: 5 additions & 0 deletions data/presets/shop/pawnbroker.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,11 @@
"shop": "pawnbroker"
},
"name": "Pawnshop",
"terms": [
"collateral",
Copy link
Copy Markdown
Contributor

@ZeLonewolf ZeLonewolf Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might apply but terminology not used in my country

Copy link
Copy Markdown
Collaborator Author

@matkoniecz matkoniecz Jan 13, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting, different US people just responded that it is used

(my question was

pawnshop questions...

Is word "collateral" used in USA?
Is typical pawnshop also selling stuff people loaned against and failed to recover?

to clarify - I am asking about collateral in pawnshop context, and not about unintentionally bombed pawnshops (as in "collateral damage")

)

I asked people on non-OSM group.

Copy link
Copy Markdown
Collaborator Author

@matkoniecz matkoniecz Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will leave it on account not being wrong and at least plausible to be used by non-natives and maybe used in USA.

"loan",
Copy link
Copy Markdown
Contributor

@ZeLonewolf ZeLonewolf Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here, loan stores are known as "payday lenders" and very different from pawn shops.

Copy link
Copy Markdown
Collaborator Author

@matkoniecz matkoniecz Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my intention is that someone typing in loan may mean either of those so listing both makes sense

"secondhand"
Copy link
Copy Markdown
Contributor

@ZeLonewolf ZeLonewolf Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A secondhand store seems very different from a pawnshop.

Copy link
Copy Markdown
Collaborator Author

@matkoniecz matkoniecz Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe it is just local oddity, but in Poland pawnshops are also selling stuff left as a collateral

is it normal elsewhere?

Copy link
Copy Markdown
Contributor

@ZeLonewolf ZeLonewolf Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's true. But there's a whole separate category of store called a secondhand shop. So if someone searches for secondhand, it should definitely put that higher in the list than pawnshop.

Copy link
Copy Markdown
Collaborator Author

@matkoniecz matkoniecz Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and it works this way!

pawnshop get listed after thrift stores (shop=second_hand) and second-hand clothing stores, which is IMHO better than not being listed at all on such search term

],
"aliases": [
"Pawnbroker",
"Pawn Shop"
Expand Down
5 changes: 4 additions & 1 deletion data/presets/shop/seafood.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,8 @@
"moreFields": [
"fhrs/id-GB"
],
"name": "Seafood Shop"
"name": "Seafood Shop",
"terms": [
"fish"
Comment thread
matkoniecz marked this conversation as resolved.
]
}
5 changes: 4 additions & 1 deletion data/presets/tourism/viewpoint.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,10 @@
"tourism": "viewpoint"
},
"terms": [
"lookout"
"lookout",
"overlook",
"scenic",
"vista"
Comment thread
matkoniecz marked this conversation as resolved.
],
"name": "Viewpoint"
}
⚡