More terms by matkoniecz · Pull Request #1892 · openstreetmap/id-tagging-schema

matkoniecz · 2026-01-13T16:50:13Z

Description, Motivation & Context

Terms were suggested by LLM and human-reviewed (>90% of suggestions were discarded for various reasons).

the main LLM command was: add missing useful search terms very likely to be used by mappers to identify given POI when searching for presets in editors, using US English, if existing terms cover it do not add it. Especially if terms has multiple words and first of them is term already then value is really low. Search terms are added in 'terms' property.

Related issues

none

Links and data

Relevant OSM Wiki links:

none

Relevant tag usage stats:

…

none

Checklist and Test-Documentation Template

Read on to get your PR merged faster…

Follow these steps to test your PR yourself and make it a lot easier and faster for maintainers to check and approve it.

This is how it works:

After you submit your PR, the system will create a preview and comment on your PR:

🍱 Your pull request preview is ready.
If this is your first contribution to this project, the preview will not happen right away but requires a click from one of the project members. We will do this ASAP.
Once the preview is ready, use it to test your changes.
Now copy the snippet below into a new comment and fill out the blanks.
Now your PR is ready to be reviewed.

## Test-Documentation

### Preview links & Sidebar Screenshots

<!-- Use the preview to find examples, select the feature in question and **copy this link here**.
     Find examples of nodes/areas. Find examples with a lot of tags or very few tags. – Whatever helps to test this thoroughly.
     Add relevant **screenshots** of the sidebar of those examples. -->

<!-- FYI: What we will check:
     - Is the [icon](https://github.com/ideditor/schema-builder/blob/main/ICONS.md) well chosen.
     - Are the fields well-structured and have good labels.
     - Do the dropdowns (etc.) work well and show helpful data. -->

### Search

<!-- **Test the search** of your preset and share relevant **screenshots** here.
     - Test the preset name as search terms.
     - Also test the preset terms and aliases as search terms (if present). -->

### Info-`i`

<!-- **Test the info-i** for your fields and preset and share relevant **screenshots** here.
     The info needs to help mappers understand the preset and when to use it.
     [Learn more…](https://github.com/openstreetmap/id-tagging-schema/blob/main/CONTRIBUTING.md#info-i)
 -->

### Wording

- [ ] American English
- [ ] `name`, `aliases` (if present) use Title Case
- [ ] `terms` (if present) use lower case, sorted A-Z
<!-- Learn more in https://github.com/openstreetmap/id-tagging-schema/blob/main/GUIDELINES.md#2-design-the-preset -->

Terms were suggested by LLM and human-reviewed (around 90% of suggestions were discarded for various reasons). the main LLM command was: `add missing useful search terms very likely to be used by mappers to identify given POI when searching for presets in editors, using US English, if existing terms cover it do not add it. Especially if terms has multiple words and first of them is term already then value is really low (search terms are added in 'terms' property)`

matkoniecz · 2026-01-13T16:50:40Z

@ZeLonewolf are you maybe interested in a review also of this one?

ZeLonewolf · 2026-01-13T16:54:35Z

+    "terms": [
+        "collateral",
+        "loan",
+        "secondhand"


A secondhand store seems very different from a pawnshop.

maybe it is just local oddity, but in Poland pawnshops are also selling stuff left as a collateral

is it normal elsewhere?

Yes, that's true. But there's a whole separate category of store called a secondhand shop. So if someone searches for secondhand, it should definitely put that higher in the list than pawnshop.

and it works this way!

pawnshop get listed after thrift stores (shop=second_hand) and second-hand clothing stores, which is IMHO better than not being listed at all on such search term

ZeLonewolf · 2026-01-13T16:55:30Z

    "name": "Pawnshop",
+    "terms": [
+        "collateral",
+        "loan",


Here, loan stores are known as "payday lenders" and very different from pawn shops.

my intention is that someone typing in loan may mean either of those so listing both makes sense

ZeLonewolf · 2026-01-13T16:56:32Z

    },
    "name": "Pawnshop",
+    "terms": [
+        "collateral",


Might apply but terminology not used in my country

interesting, different US people just responded that it is used

(my question was

pawnshop questions...

Is word "collateral" used in USA?
Is typical pawnshop also selling stuff people loaned against and failed to recover?

to clarify - I am asking about collateral in pawnshop context, and not about unintentionally bombed pawnshops (as in "collateral damage")

)

I asked people on non-OSM group.

I will leave it on account not being wrong and at least plausible to be used by non-natives and maybe used in USA.

ZeLonewolf · 2026-01-13T16:58:33Z

@@ -15,5 +15,13 @@
        "shop": "fuel"
    },
    "name": "Fuel Shop",


Not familiar enough with this type of store to know if these items are typically sold there.

github-actions · 2026-01-13T17:01:00Z

🍱 Your pull request preview is ready

Please use this preview to check your changes. Ideally use the test documentation template and document your test results by commenting on the PR. This will speed up the review process for everyone.

FYI, once this PR is merged, you can use the iD Editor Preview to test your changes in interaction with all other changes.

Co-authored-by: Flo Edelmann <git@flo-edelmann.de>

FloEdelmann · 2026-01-23T20:09:09Z

+        "kerosene",
+        "pellets"
+    ],
    "matchScore": 0.5


Since this has a match score of 0.5, maybe adding more presets to make it easier to be found is actually counterproductive?

I guess I can check why it got so low match score

But these terms are quite indicative it is this (what else should match?) so I am fine with it

And at least for this shop I sadly have experience with them (hello from low emission hell, on next day of "better stay indoor and do not open windows" warnings)

low match score is as far as I know to keep gas station higher

Co-authored-by: Flo Edelmann <git@flo-edelmann.de>

tyrasd

matkoniecz added 3 commits January 12, 2026 05:15

cheesemonger is not in real modern use

633e555

drop defunct nouns

4473958

matkoniecz added new-label changes the name, aliases or terms of a preset search-related labels Jan 13, 2026

matkoniecz closed this Jan 13, 2026

matkoniecz reopened this Jan 13, 2026

ZeLonewolf reviewed Jan 13, 2026

View reviewed changes

dropping panorama

fd3c17c

FloEdelmann reviewed Jan 23, 2026

View reviewed changes

Comment thread data/presets/tourism/viewpoint.json

add more terms

a2e71f8

Co-authored-by: Flo Edelmann <git@flo-edelmann.de>

FloEdelmann reviewed Jan 23, 2026

View reviewed changes

Comment thread data/presets/shop/mobile_phone.json

FloEdelmann reviewed Jan 23, 2026

View reviewed changes

Comment thread data/presets/shop/mobile_phone_accessories.json

FloEdelmann mentioned this pull request Jan 23, 2026

Add more terms to shop presets #1906

Merged

tyrasd and others added 2 commits January 27, 2026 11:22

Update data/presets/shop/mobile_phone.json

89bc2ea

Co-authored-by: Flo Edelmann <git@flo-edelmann.de>

Update data/presets/shop/mobile_phone_accessories.json

3a5d221

Co-authored-by: Flo Edelmann <git@flo-edelmann.de>

tyrasd approved these changes Jan 27, 2026

View reviewed changes

tyrasd merged commit 1d214cb into openstreetmap:main Jan 27, 2026
5 checks passed

Conversation

matkoniecz commented Jan 13, 2026

Description, Motivation & Context

Related issues

Links and data

Checklist and Test-Documentation Template

Uh oh!

matkoniecz commented Jan 13, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

matkoniecz Jan 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jan 13, 2026

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

tyrasd left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

matkoniecz Jan 13, 2026 •

edited

Loading