Skip to content

Add more terms to shop presets#1906

Merged
tyrasd merged 5 commits intoopenstreetmap:mainfrom
FloEdelmann:terms/shops
Jan 27, 2026
Merged

Add more terms to shop presets#1906
tyrasd merged 5 commits intoopenstreetmap:mainfrom
FloEdelmann:terms/shops

Conversation

@FloEdelmann
Copy link
Copy Markdown
Contributor

Description, Motivation & Context

Inspired by #1892, I also asked an LLM (GPT-5 mini via GitHub Copilot) to generate new terms. I used the following prompt:

For each JSON preset, add useful missing search terms that are likely to be used by mappers to identify a given POI when searching for presets in editors. Only use lowercase US English for search terms and add them in the terms property. Do not add terms that are covered by existing terms. Do not write a script but add the terms directly to the JSON files.

However, it needed constant convincing to not write a script that would convert name or tags to (useless) terms, and would only do a few presets at a time. From its suggestions, I threw a lot away. I also did not change any presets changed by @matkoniecz in #1892. For the remaining suggestions I manually checked in iD that they were not already found.

@ZeLonewolf your review would again be appreciated 🙂

Related issues

None.

Links and data

Relevant OSM Wiki links: None.
Relevant tag usage stats: None.

Checklist and Test-Documentation Template

Read on to get your PR merged faster…

Follow these steps to test your PR yourself and make it a lot easier and faster for maintainers to check and approve it.

This is how it works:

  1. After you submit your PR, the system will create a preview and comment on your PR:

    🍱 Your pull request preview is ready.
    If this is your first contribution to this project, the preview will not happen right away but requires a click from one of the project members. We will do this ASAP.

  2. Once the preview is ready, use it to test your changes.

  3. Now copy the snippet below into a new comment and fill out the blanks.

  4. Now your PR is ready to be reviewed.

## Test-Documentation

### Preview links & Sidebar Screenshots

<!-- Use the preview to find examples, select the feature in question and **copy this link here**.
     Find examples of nodes/areas. Find examples with a lot of tags or very few tags. – Whatever helps to test this thoroughly.
     Add relevant **screenshots** of the sidebar of those examples. -->

<!-- FYI: What we will check:
     - Is the [icon](https://github.com/ideditor/schema-builder/blob/main/ICONS.md) well chosen.
     - Are the fields well-structured and have good labels.
     - Do the dropdowns (etc.) work well and show helpful data. -->

### Search

<!-- **Test the search** of your preset and share relevant **screenshots** here.
     - Test the preset name as search terms.
     - Also test the preset terms and aliases as search terms (if present). -->

### Info-`i`

<!-- **Test the info-i** for your fields and preset and share relevant **screenshots** here.
     The info needs to help mappers understand the preset and when to use it.
     [Learn more…](https://github.com/openstreetmap/id-tagging-schema/blob/main/CONTRIBUTING.md#info-i)
 -->

### Wording

- [x] American English
- [x] `name`, `aliases` (if present) use Title Case
- [x] `terms` (if present) use lower case, sorted A-Z
<!-- Learn more in https://github.com/openstreetmap/id-tagging-schema/blob/main/GUIDELINES.md#2-design-the-preset -->

@github-actions
Copy link
Copy Markdown

🍱 Your pull request preview is ready

Please use this preview to check your changes. Ideally use the test documentation template and document your test results by commenting on the PR. This will speed up the review process for everyone.

FYI, once this PR is merged, you can use the iD Editor Preview to test your changes in interaction with all other changes.

"terms": [
"cocoa"
"cocoa",
"confectionery"
Copy link
Copy Markdown
Contributor Author

@FloEdelmann FloEdelmann Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is also shop=confectionery and craft=confectionery, but I think showing all those presets as search results for that term makes sense.

Comment thread data/presets/shop/fashion_accessories.json Outdated
"terms": [
"cookware",
"home",
"home goods",
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Searching for "home goods" currently does not match this preset, even though both words are contained in terms + alias. So adding makes sense I guess.

"blueray",
"camera",
"computer",
"consumer electronics",
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, it was not being found?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, when searching for "consumer electronics", the electronics shop preset does not show up.

"computer",
"consumer electronics",
"dvd",
"gadgets",
Copy link
Copy Markdown
Collaborator

@matkoniecz matkoniecz Jan 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also to shop=gift?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure, but in my experience (and Wikipedia agrees) a gadget is an electronic or mechanical device. Seems not fitting for shop=gift.

Copy link
Copy Markdown
Collaborator

@matkoniecz matkoniecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would drop purfume

Comment thread data/presets/shop/second_hand.json
Comment thread data/presets/shop/second_hand.json
@tyrasd tyrasd merged commit 452704d into openstreetmap:main Jan 27, 2026
5 checks passed
@tyrasd tyrasd added the new-label changes the name, aliases or terms of a preset label Jan 27, 2026
@FloEdelmann FloEdelmann deleted the terms/shops branch January 27, 2026 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-label changes the name, aliases or terms of a preset

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants