Add more terms to shop presets#1906
Conversation
|
🍱 Your pull request preview is ready Please use this preview to check your changes. Ideally use the test documentation template and document your test results by commenting on the PR. This will speed up the review process for everyone. FYI, once this PR is merged, you can use the iD Editor Preview to test your changes in interaction with all other changes. |
| "terms": [ | ||
| "cocoa" | ||
| "cocoa", | ||
| "confectionery" |
There was a problem hiding this comment.
There is also shop=confectionery and craft=confectionery, but I think showing all those presets as search results for that term makes sense.
| "terms": [ | ||
| "cookware", | ||
| "home", | ||
| "home goods", |
There was a problem hiding this comment.
Searching for "home goods" currently does not match this preset, even though both words are contained in terms + alias. So adding makes sense I guess.
| "blueray", | ||
| "camera", | ||
| "computer", | ||
| "consumer electronics", |
There was a problem hiding this comment.
Wait, it was not being found?
There was a problem hiding this comment.
No, when searching for "consumer electronics", the electronics shop preset does not show up.
| "computer", | ||
| "consumer electronics", | ||
| "dvd", | ||
| "gadgets", |
There was a problem hiding this comment.
Not sure, but in my experience (and Wikipedia agrees) a gadget is an electronic or mechanical device. Seems not fitting for shop=gift.
matkoniecz
left a comment
There was a problem hiding this comment.
I would drop purfume
Description, Motivation & Context
Inspired by #1892, I also asked an LLM (GPT-5 mini via GitHub Copilot) to generate new terms. I used the following prompt:
However, it needed constant convincing to not write a script that would convert name or tags to (useless) terms, and would only do a few presets at a time. From its suggestions, I threw a lot away. I also did not change any presets changed by @matkoniecz in #1892. For the remaining suggestions I manually checked in iD that they were not already found.
@ZeLonewolf your review would again be appreciated 🙂
Related issues
None.
Links and data
Relevant OSM Wiki links: None.
Relevant tag usage stats: None.
Checklist and Test-Documentation Template
Read on to get your PR merged faster…
Follow these steps to test your PR yourself and make it a lot easier and faster for maintainers to check and approve it.
This is how it works:
After you submit your PR, the system will create a preview and comment on your PR:
Once the preview is ready, use it to test your changes.
Now copy the snippet below into a new comment and fill out the blanks.
Now your PR is ready to be reviewed.