Skip to content

Add more terms to non-food amenity presets#1909

Merged
tyrasd merged 3 commits intoopenstreetmap:mainfrom
FloEdelmann:terms/other-amenities
Jan 27, 2026
Merged

Add more terms to non-food amenity presets#1909
tyrasd merged 3 commits intoopenstreetmap:mainfrom
FloEdelmann:terms/other-amenities

Conversation

@FloEdelmann
Copy link
Copy Markdown
Contributor

@FloEdelmann FloEdelmann commented Jan 23, 2026

Description, Motivation & Context

In the same LLM session as in #1906, some useful suggestions for food amenity presets were also made. Again, I threw a lot of suggestions away and manually checked the others in iD.

@ZeLonewolf and @matkoniecz your reviews would again be appreciated 🙂

And this is the last PR from that LLM session. I'll likely not repeat this anytime soon 😅

Related issues

None.

Links and data

Relevant OSM Wiki links: None.
Relevant tag usage stats: None.

Checklist and Test-Documentation Template

Read on to get your PR merged faster…

Follow these steps to test your PR yourself and make it a lot easier and faster for maintainers to check and approve it.

This is how it works:

  1. After you submit your PR, the system will create a preview and comment on your PR:

    🍱 Your pull request preview is ready.
    If this is your first contribution to this project, the preview will not happen right away but requires a click from one of the project members. We will do this ASAP.

  2. Once the preview is ready, use it to test your changes.

  3. Now copy the snippet below into a new comment and fill out the blanks.

  4. Now your PR is ready to be reviewed.

## Test-Documentation

### Preview links & Sidebar Screenshots

<!-- Use the preview to find examples, select the feature in question and **copy this link here**.
     Find examples of nodes/areas. Find examples with a lot of tags or very few tags. – Whatever helps to test this thoroughly.
     Add relevant **screenshots** of the sidebar of those examples. -->

<!-- FYI: What we will check:
     - Is the [icon](https://github.com/ideditor/schema-builder/blob/main/ICONS.md) well chosen.
     - Are the fields well-structured and have good labels.
     - Do the dropdowns (etc.) work well and show helpful data. -->

### Search

<!-- **Test the search** of your preset and share relevant **screenshots** here.
     - Test the preset name as search terms.
     - Also test the preset terms and aliases as search terms (if present). -->

### Info-`i`

<!-- **Test the info-i** for your fields and preset and share relevant **screenshots** here.
     The info needs to help mappers understand the preset and when to use it.
     [Learn more…](https://github.com/openstreetmap/id-tagging-schema/blob/main/CONTRIBUTING.md#info-i)
 -->

### Wording

- [ ] American English
- [ ] `name`, `aliases` (if present) use Title Case
- [ ] `terms` (if present) use lower case, sorted A-Z
<!-- Learn more in https://github.com/openstreetmap/id-tagging-schema/blob/main/GUIDELINES.md#2-design-the-preset -->

Comment on lines +26 to 32
"terms": [
"car pool",
"carpooling",
"lift sharing",
"ride sharing"
],
"name": "Car Sharing Station"
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These terms + name align the search terms to amenity=car_pooling, so both presets are found with similar terms.

"mailbox",
"mailhole",
"mailslot",
"post box",
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this missing on purpose, to not confuse this with amenity=post_box?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure, but it's fine to include it as the "proper" preset is still first in the results list when searching for post box.

@github-actions
Copy link
Copy Markdown

🍱 Your pull request preview is ready

Please use this preview to check your changes. Ideally use the test documentation template and document your test results by commenting on the PR. This will speed up the review process for everyone.

FYI, once this PR is merged, you can use the iD Editor Preview to test your changes in interaction with all other changes.

Comment thread data/presets/amenity/bank.json Outdated
"terms": [
"book"
"book",
"public library",
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this term not finding it already?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, when searching for "public library", the library preset does not show up.

@tyrasd tyrasd added the new-label changes the name, aliases or terms of a preset label Jan 27, 2026
tyrasd and others added 2 commits January 27, 2026 11:31
Co-authored-by: Flo Edelmann <git@flo-edelmann.de>
Copy link
Copy Markdown
Member

@tyrasd tyrasd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me. I added trough as an exception to the spellchecker workflow because it was a false positive.

@tyrasd tyrasd merged commit b439bcb into openstreetmap:main Jan 27, 2026
5 checks passed
@FloEdelmann FloEdelmann deleted the terms/other-amenities branch January 27, 2026 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-label changes the name, aliases or terms of a preset

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants