Add more terms to non-food amenity presets#1909
Conversation
| "terms": [ | ||
| "car pool", | ||
| "carpooling", | ||
| "lift sharing", | ||
| "ride sharing" | ||
| ], | ||
| "name": "Car Sharing Station" |
There was a problem hiding this comment.
These terms + name align the search terms to amenity=car_pooling, so both presets are found with similar terms.
| "mailbox", | ||
| "mailhole", | ||
| "mailslot", | ||
| "post box", |
There was a problem hiding this comment.
Was this missing on purpose, to not confuse this with amenity=post_box?
There was a problem hiding this comment.
not sure, but it's fine to include it as the "proper" preset is still first in the results list when searching for post box.
|
🍱 Your pull request preview is ready Please use this preview to check your changes. Ideally use the test documentation template and document your test results by commenting on the PR. This will speed up the review process for everyone. FYI, once this PR is merged, you can use the iD Editor Preview to test your changes in interaction with all other changes. |
| "terms": [ | ||
| "book" | ||
| "book", | ||
| "public library", |
There was a problem hiding this comment.
Is this term not finding it already?
There was a problem hiding this comment.
No, when searching for "public library", the library preset does not show up.
Co-authored-by: Flo Edelmann <git@flo-edelmann.de>
tyrasd
left a comment
There was a problem hiding this comment.
Thanks, looks good to me. I added trough as an exception to the spellchecker workflow because it was a false positive.
Description, Motivation & Context
In the same LLM session as in #1906, some useful suggestions for food amenity presets were also made. Again, I threw a lot of suggestions away and manually checked the others in iD.
@ZeLonewolf and @matkoniecz your reviews would again be appreciated 🙂
And this is the last PR from that LLM session. I'll likely not repeat this anytime soon 😅
Related issues
None.
Links and data
Relevant OSM Wiki links: None.
Relevant tag usage stats: None.
Checklist and Test-Documentation Template
Read on to get your PR merged faster…
Follow these steps to test your PR yourself and make it a lot easier and faster for maintainers to check and approve it.
This is how it works:
After you submit your PR, the system will create a preview and comment on your PR:
Once the preview is ready, use it to test your changes.
Now copy the snippet below into a new comment and fill out the blanks.
Now your PR is ready to be reviewed.