Skip to content

Add strings for flag:type#1899

Merged
tyrasd merged 1 commit intoopenstreetmap:mainfrom
1ec5:flag-type-strings
Jan 27, 2026
Merged

Add strings for flag:type#1899
tyrasd merged 1 commit intoopenstreetmap:mainfrom
1ec5:flag-type-strings

Conversation

@1ec5
Copy link
Copy Markdown
Contributor

@1ec5 1ec5 commented Jan 20, 2026

Added strings for several documented flag:type=* values to the Flag Type field. This covers all the values that name-suggestion-index uses.

Of the most common values, the only undocumented ones are commercial, company, enterprise, state, decorative, and city. Most of these values seem to overlap documented values. I’m open to adding decorative, since it seems pretty unambiguous. @westnordost once pointed out to me that these are popular landmarks in allotments in Germany.

I omitted signal because I’m unsure what it actually means.

@github-actions
Copy link
Copy Markdown

🍱 Your pull request preview is ready

Please use this preview to check your changes. Ideally use the test documentation template and document your test results by commenting on the PR. This will speed up the review process for everyone.

FYI, once this PR is merged, you can use the iD Editor Preview to test your changes in interaction with all other changes.

@matkoniecz
Copy link
Copy Markdown
Collaborator

Please use this preview to check your changes.

Have you done this? Change seems pretty safe but...

@1ec5
Copy link
Copy Markdown
Contributor Author

1ec5 commented Jan 24, 2026

Looks OK to me:

National, Advertising, Regional…

@tyrasd tyrasd added the new-value adds value(s) to existing field label Jan 27, 2026
@tyrasd tyrasd merged commit c6680f6 into openstreetmap:main Jan 27, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-value adds value(s) to existing field

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants