Skip to content

Add missing inheritance in moreFields#2020

Merged
tordans merged 8 commits intomainfrom
matkoniecz-patch-18
Mar 10, 2026
Merged

Add missing inheritance in moreFields#2020
tordans merged 8 commits intomainfrom
matkoniecz-patch-18

Conversation

@matkoniecz
Copy link
Copy Markdown
Collaborator

part of #1819
fixes #987

Description, Motivation & Context

Related issues

Links and data

Relevant OSM Wiki links:

Relevant tag usage stats:

Checklist and Test-Documentation Template

Read on to get your PR merged faster…

Follow these steps to test your PR yourself and make it a lot easier and faster for maintainers to check and approve it.

This is how it works:

  1. After you submit your PR, the system will create a preview and comment on your PR:

    🍱 Your pull request preview is ready.
    If this is your first contribution to this project, the preview will not happen right away but requires a click from one of the project members. We will do this ASAP.

  2. Once the preview is ready, use it to test your changes.

  3. Now copy the snippet below into a new comment and fill out the blanks.

  4. Now your PR is ready to be reviewed.

## Test-Documentation

### Preview links & Sidebar Screenshots

<!-- Use the preview to find examples, select the feature in question and **copy this link here**.
     Find examples of nodes/areas. Find examples with a lot of tags or very few tags. – Whatever helps to test this thoroughly.
     Add relevant **screenshots** of the sidebar of those examples. -->

<!-- FYI: What we will check:
     - Is the [icon](https://github.com/ideditor/schema-builder/blob/main/ICONS.md) well chosen.
     - Are the fields well-structured and have good labels.
     - Do the dropdowns (etc.) work well and show helpful data. -->

### Search

<!-- **Test the search** of your preset and share relevant **screenshots** here.
     - Test the preset name as search terms.
     - Also test the preset terms and aliases as search terms (if present). -->

### Info-`i`

<!-- **Test the info-i** for your fields and preset and share relevant **screenshots** here.
     The info needs to help mappers understand the preset and when to use it.
     [Learn more…](https://github.com/openstreetmap/id-tagging-schema/blob/main/CONTRIBUTING.md#info-i)
 -->

### Wording

- [ ] American English
- [ ] `name`, `aliases` (if present) use Title Case
- [ ] `terms` (if present) use lower case, sorted A-Z
<!-- Learn more in https://github.com/openstreetmap/id-tagging-schema/blob/main/GUIDELINES.md#2-design-the-preset -->

@matkoniecz matkoniecz changed the title Add '{craft}' to moreFields in caterer.json Add '{craft}' to moreFields in craft= Mar 9, 2026
@github-actions
Copy link
Copy Markdown

🍱 Your pull request preview is ready

Please use this preview to check your changes. Ideally use the test documentation template and document your test results by commenting on the PR. This will speed up the review process for everyone.

FYI, once this PR is merged, you can use the iD Editor Preview to test your changes in interaction with all other changes.

@matkoniecz matkoniecz force-pushed the matkoniecz-patch-18 branch from 23aeeeb to 60ebb41 Compare March 10, 2026 00:10
@matkoniecz matkoniecz changed the title Add '{craft}' to moreFields in craft= Add missing inheritance in moreFields Mar 10, 2026
@tordans tordans merged commit 98dce72 into main Mar 10, 2026
8 checks passed
@matkoniecz matkoniecz added field add-field add existing field to more entries, for field creation see new-field and removed field labels Mar 10, 2026
@matkoniecz
Copy link
Copy Markdown
Collaborator Author

Hmm, what is the difference between field and add-field?

@matkoniecz matkoniecz deleted the matkoniecz-patch-18 branch March 10, 2026 07:29
@tordans
Copy link
Copy Markdown
Collaborator

tordans commented Mar 10, 2026

add-field

You mean the label? AFAIK those dont have a strong definition. They are used to sort the commits when drafting the release https://github.com/search?q=repo%3Aopenstreetmap%2Fid-tagging-schema%20add-field&type=code
And just a soft category for users…

@matkoniecz
Copy link
Copy Markdown
Collaborator Author

matkoniecz commented Mar 10, 2026

You mean the label?

yes

From looking at

it seems that impact of differences is nearly zero as all go into the same category anyway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

add-field add existing field to more entries, for field creation see new-field

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants