Try radio selector for Direction fields#2081
Conversation
|
🍱 Your pull request preview is ready Please use this preview to check your changes. Ideally use the test documentation template and document your test results by commenting on the PR. This will speed up the review process for everyone. FYI, once this PR is merged, you can use the iD Editor Preview to test your changes in interaction with all other changes. |
tordans
left a comment
There was a problem hiding this comment.
I agree, this is better.
The only thing that we could look out for: The screenshots above are all features that are very focused with few fields. Should those fields be used in cases where we have many fields and this field is not something very important there, then we will give it more prominence with this change. But IMO it is OK to merge and fix later should we notice any cases… |
|
I already went looking through cases where these fields are used and not found any with massive list of properties. Though I have not tested each. It is kind of expected, given that direction field is likely to be on subsidiary property, not primary one like road/POI. |
|
BTW, if this goes through then https://github.com/openstreetmap/id-tagging-schema/blob/main/data/fields/direction_vertex_dual.json would be next to change. |




part of #2049
Description, Motivation & Context
Related issues
Links and data
Relevant OSM Wiki links:
Relevant tag usage stats:
Checklist and Test-Documentation Template
Read on to get your PR merged faster…
Follow these steps to test your PR yourself and make it a lot easier and faster for maintainers to check and approve it.
This is how it works:
After you submit your PR, the system will create a preview and comment on your PR:
Once the preview is ready, use it to test your changes.
Now copy the snippet below into a new comment and fill out the blanks.
Now your PR is ready to be reviewed.