Skip to content

Try radio selector for Direction fields#2081

Merged
tyrasd merged 1 commit intoopenstreetmap:mainfrom
matkoniecz:radio
Mar 23, 2026
Merged

Try radio selector for Direction fields#2081
tyrasd merged 1 commit intoopenstreetmap:mainfrom
matkoniecz:radio

Conversation

@matkoniecz
Copy link
Copy Markdown
Collaborator

part of #2049

Description, Motivation & Context

Related issues

Links and data

Relevant OSM Wiki links:

Relevant tag usage stats:

Checklist and Test-Documentation Template

Read on to get your PR merged faster…

Follow these steps to test your PR yourself and make it a lot easier and faster for maintainers to check and approve it.

This is how it works:

  1. After you submit your PR, the system will create a preview and comment on your PR:

    🍱 Your pull request preview is ready.
    If this is your first contribution to this project, the preview will not happen right away but requires a click from one of the project members. We will do this ASAP.

  2. Once the preview is ready, use it to test your changes.

  3. Now copy the snippet below into a new comment and fill out the blanks.

  4. Now your PR is ready to be reviewed.

## Test-Documentation

### Preview links & Sidebar Screenshots

<!-- Use the preview to find examples, select the feature in question and **copy this link here**.
     Find examples of nodes/areas. Find examples with a lot of tags or very few tags. – Whatever helps to test this thoroughly.
     Add relevant **screenshots** of the sidebar of those examples. -->

<!-- FYI: What we will check:
     - Is the [icon](https://github.com/ideditor/schema-builder/blob/main/ICONS.md) well chosen.
     - Are the fields well-structured and have good labels.
     - Do the dropdowns (etc.) work well and show helpful data. -->

### Search

<!-- **Test the search** of your preset and share relevant **screenshots** here.
     - Test the preset name as search terms.
     - Also test the preset terms and aliases as search terms (if present). -->

### Info-`i`

<!-- **Test the info-i** for your fields and preset and share relevant **screenshots** here.
     The info needs to help mappers understand the preset and when to use it.
     [Learn more…](https://github.com/openstreetmap/id-tagging-schema/blob/main/CONTRIBUTING.md#info-i)
 -->

### Wording

- [ ] American English
- [ ] `name`, `aliases` (if present) use Title Case
- [ ] `terms` (if present) use lower case, sorted A-Z
<!-- Learn more in https://github.com/openstreetmap/id-tagging-schema/blob/main/GUIDELINES.md#2-design-the-preset -->

@github-actions
Copy link
Copy Markdown

🍱 Your pull request preview is ready

Please use this preview to check your changes. Ideally use the test documentation template and document your test results by commenting on the PR. This will speed up the review process for everyone.

FYI, once this PR is merged, you can use the iD Editor Preview to test your changes in interaction with all other changes.

@matkoniecz
Copy link
Copy Markdown
Collaborator Author

looks like improvement, especially as this appears in presets where UI is not several kilometers long, so extra height is not so problematic

screen-2026-03-18-11-47-07 screen-2026-03-18-11-46-37 screen-2026-03-18-11-45-51 screen-2026-03-18-11-45-13

@matkoniecz matkoniecz marked this pull request as ready for review March 18, 2026 10:56
Copy link
Copy Markdown
Collaborator

@tordans tordans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, this is better.

@tordans
Copy link
Copy Markdown
Collaborator

tordans commented Mar 18, 2026

I agree, this is better.

The only thing that we could look out for: The screenshots above are all features that are very focused with few fields. Should those fields be used in cases where we have many fields and this field is not something very important there, then we will give it more prominence with this change.

But IMO it is OK to merge and fix later should we notice any cases…

@matkoniecz
Copy link
Copy Markdown
Collaborator Author

matkoniecz commented Mar 18, 2026

I already went looking through cases where these fields are used and not found any with massive list of properties. Though I have not tested each.

It is kind of expected, given that direction field is likely to be on subsidiary property, not primary one like road/POI.

@matkoniecz
Copy link
Copy Markdown
Collaborator Author

@tordans tordans added the field label Mar 18, 2026
@matkoniecz
Copy link
Copy Markdown
Collaborator Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants