Skip to content

less generic icon for building=service - thanks to enzet for an icon#2089

Merged
tyrasd merged 1 commit intomainfrom
matkoniecz-patch-20
Mar 23, 2026
Merged

less generic icon for building=service - thanks to enzet for an icon#2089
tyrasd merged 1 commit intomainfrom
matkoniecz-patch-20

Conversation

@matkoniecz
Copy link
Copy Markdown
Collaborator

@matkoniecz matkoniecz commented Mar 19, 2026

Description, Motivation & Context

icon from enzet/Roentgen#24

Related issues

part of #41

Links and data

Relevant OSM Wiki links:

https://wiki.openstreetmap.org/wiki/Tag:building%3Dservice

Relevant tag usage stats:

Checklist and Test-Documentation Template

Read on to get your PR merged faster…

Follow these steps to test your PR yourself and make it a lot easier and faster for maintainers to check and approve it.

This is how it works:

  1. After you submit your PR, the system will create a preview and comment on your PR:

    🍱 Your pull request preview is ready.
    If this is your first contribution to this project, the preview will not happen right away but requires a click from one of the project members. We will do this ASAP.

  2. Once the preview is ready, use it to test your changes.

  3. Now copy the snippet below into a new comment and fill out the blanks.

  4. Now your PR is ready to be reviewed.

## Test-Documentation

### Preview links & Sidebar Screenshots

<!-- Use the preview to find examples, select the feature in question and **copy this link here**.
     Find examples of nodes/areas. Find examples with a lot of tags or very few tags. – Whatever helps to test this thoroughly.
     Add relevant **screenshots** of the sidebar of those examples. -->

<!-- FYI: What we will check:
     - Is the [icon](https://github.com/ideditor/schema-builder/blob/main/ICONS.md) well chosen.
     - Are the fields well-structured and have good labels.
     - Do the dropdowns (etc.) work well and show helpful data. -->

### Search

<!-- **Test the search** of your preset and share relevant **screenshots** here.
     - Test the preset name as search terms.
     - Also test the preset terms and aliases as search terms (if present). -->

### Info-`i`

<!-- **Test the info-i** for your fields and preset and share relevant **screenshots** here.
     The info needs to help mappers understand the preset and when to use it.
     [Learn more…](https://github.com/openstreetmap/id-tagging-schema/blob/main/CONTRIBUTING.md#info-i)
 -->

### Wording

- [ ] American English
- [ ] `name`, `aliases` (if present) use Title Case
- [ ] `terms` (if present) use lower case, sorted A-Z
<!-- Learn more in https://github.com/openstreetmap/id-tagging-schema/blob/main/GUIDELINES.md#2-design-the-preset -->

thanks to enzet for an icon

part of #41

icon from enzet/Roentgen#24
@matkoniecz matkoniecz changed the title less generic icon for building=service less generic icon for building=service - thanks to enzet for an icon Mar 19, 2026
@github-actions
Copy link
Copy Markdown

🍱 Your pull request preview is ready

Please use this preview to check your changes. Ideally use the test documentation template and document your test results by commenting on the PR. This will speed up the review process for everyone.

FYI, once this PR is merged, you can use the iD Editor Preview to test your changes in interaction with all other changes.

@matkoniecz
Copy link
Copy Markdown
Collaborator Author

screen-2026-03-19-17-00-06

current, uniquely not fitting, even for https://en.wikipedia.org/wiki/33_Thomas_Street

screen-2026-03-19-17-01-00

@matkoniecz matkoniecz marked this pull request as ready for review March 19, 2026 16:05
@tyrasd tyrasd merged commit ddf9ad1 into main Mar 23, 2026
8 checks passed
@tyrasd tyrasd deleted the matkoniecz-patch-20 branch March 23, 2026 10:54
@matkoniecz
Copy link
Copy Markdown
Collaborator Author

again thanks to @enzet (if you prefer to not be credited in release notes and PR titles or credited differently - let me know)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants