Skip to content

Switch incline_steps to radio field#2141

Merged
tyrasd merged 1 commit intomainfrom
matkoniecz-patch-5
Apr 7, 2026
Merged

Switch incline_steps to radio field#2141
tyrasd merged 1 commit intomainfrom
matkoniecz-patch-5

Conversation

@matkoniecz
Copy link
Copy Markdown
Collaborator

With this change just selector is not enough at all.

iD, maybe other data consumers, really should get request along 'For incline=up/down show which end is up' lines

maybe such hint should be part of iD tagging schema? Which other fields would benefit from such hint?

Description, Motivation & Context

see #2049

Related issues

part of #2049

Links and data

Relevant OSM Wiki links:

Relevant tag usage stats:

Checklist and Test-Documentation Template

Read on to get your PR merged faster…

Follow these steps to test your PR yourself and make it a lot easier and faster for maintainers to check and approve it.

This is how it works:

  1. After you submit your PR, the system will create a preview and comment on your PR:

    🍱 Your pull request preview is ready.
    If this is your first contribution to this project, the preview will not happen right away but requires a click from one of the project members. We will do this ASAP.

  2. Once the preview is ready, use it to test your changes.

  3. Now copy the snippet below into a new comment and fill out the blanks.

  4. Now your PR is ready to be reviewed.

## Test-Documentation

### Preview links & Sidebar Screenshots

<!-- Use the preview to find examples, select the feature in question and **copy this link here**.
     Find examples of nodes/areas. Find examples with a lot of tags or very few tags. – Whatever helps to test this thoroughly.
     Add relevant **screenshots** of the sidebar of those examples. -->

<!-- FYI: What we will check:
     - Is the [icon](https://github.com/ideditor/schema-builder/blob/main/ICONS.md) well chosen.
     - Are the fields well-structured and have good labels.
     - Do the dropdowns (etc.) work well and show helpful data. -->

### Search

<!-- **Test the search** of your preset and share relevant **screenshots** here.
     - Test the preset name as search terms.
     - Also test the preset terms and aliases as search terms (if present). -->

### Info-`i`

<!-- **Test the info-i** for your fields and preset and share relevant **screenshots** here.
     The info needs to help mappers understand the preset and when to use it.
     [Learn more…](https://github.com/openstreetmap/id-tagging-schema/blob/main/CONTRIBUTING.md#info-i)
 -->

### Wording

- [ ] American English
- [ ] `name`, `aliases` (if present) use Title Case
- [ ] `terms` (if present) use lower case, sorted A-Z
<!-- Learn more in https://github.com/openstreetmap/id-tagging-schema/blob/main/GUIDELINES.md#2-design-the-preset -->

With this change just selector is not enough at all.

iD, maybe other data consumers, really should get request along 'For incline=up/down show which end is up' lines

maybe such hint should be part of iD tagging schema? Which other fields would benefit from such hint?
@matkoniecz
Copy link
Copy Markdown
Collaborator Author

after this is merged: create mentioned iD issue, maybe schema builder issue, maybe GoMap!! issue, maybe for other data consumers

take look at #2049 (comment) an open next radio PR

@github-actions
Copy link
Copy Markdown

🍱 Your pull request preview is ready

Please use this preview to check your changes. Ideally use the test documentation template and document your test results by commenting on the PR. This will speed up the review process for everyone.

FYI, once this PR is merged, you can use the iD Editor Preview to test your changes in interaction with all other changes.

@matkoniecz
Copy link
Copy Markdown
Collaborator Author

@matkoniecz matkoniecz marked this pull request as draft March 31, 2026 17:57
@matkoniecz
Copy link
Copy Markdown
Collaborator Author

@matkoniecz matkoniecz marked this pull request as ready for review April 1, 2026 02:43
@tyrasd tyrasd merged commit acbbdf9 into main Apr 7, 2026
8 checks passed
@tyrasd tyrasd changed the title Switch incline_steps to radio Switch incline_steps to radio field Apr 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants