Add Barrack Building as a value for building type dropdown

[ak8abhinay]

Adds new preset for building=barracks

wiki : https://wiki.openstreetmap.org/wiki/Tag:building%3Dbarracks

Fixes #2156

[github-actions]

🍱 Your pull request preview is ready

Please use this preview to check your changes. Ideally use the test documentation template and document your test results by commenting on the PR. This will speed up the review process for everyone.

FYI, once this PR is merged, you can use the iD Editor Preview to test your changes in interaction with all other changes.

[ak8abhinay]

Here is a screenshot of the preset working in the iD editor.

Building type dropdown :

[matkoniecz]

I am not sure yet should it get own building preset or is dropdown in building type enough.

But tent icon is definitely bad.

[ak8abhinay]

I am not sure yet should it get own building preset or is dropdown in building type enough

Even I wasn't sure initially. But after looking at the building types like Yurt which has its own preset as well as dropdown and even statistics wise where only 944 is the tag usage or Hanger Building , pigsty which have both its own preset and dropdown as well.

But tent icon is definitely bad

Agree.
Another option we have is :

[matkoniecz]

Problem with barracks is that distinct building type is quite dubious and there is much greater risk of people misusing it for the current use. In fact the second icon (with flag) would make it even worse: if soldiers leave and flag is removed then it should be still tagged building=barracks. Or it should not be tagged as building=barracks in the first place.

Having it as dropdown of building type makes it more clear that it is about building type, not about building use.

In fact, do we have preset for things currently used as barracks?

[ak8abhinay]

do we have preset for things currently used as barracks?

military=barracks already exists as a preset in iD.

I totally agree the existing preset covers the situation where one can map an active military barracks and if wants to tags the building on top of that can be best served by the dropdown.