Skip to content

Add more denominations as search terms to Christian place_of_worship#2172

Merged
matkoniecz merged 2 commits intoopenstreetmap:mainfrom
michaelblyons:denomination-1
Apr 15, 2026
Merged

Add more denominations as search terms to Christian place_of_worship#2172
matkoniecz merged 2 commits intoopenstreetmap:mainfrom
michaelblyons:denomination-1

Conversation

@michaelblyons
Copy link
Copy Markdown
Contributor

Description, Motivation & Context

In the spirit of #2028, adds more high-use denominations from taginfo that do not currently appear in a freeform search on iD.

Some search terms have NSI results for other data types (Adventist hospital, LDS school).

Related issues

Links and data

Relevant OSM Wiki links:

Relevant tag usage stats:

https://taginfo.openstreetmap.org/keys/denomination#values

  • orthodox: 36_735 + *_orthodox: 54_704 = 91_444 (the big one)
  • protestant: 30_054
  • presbyterian: 11_477 + ~200 assorted variants
  • mormon: 8_581
  • seventh_day_adventist: 6_146 + adventist: 792 = 6_939
  • reformed: 5_114 + *_reformed: ~1_200 = ~6_300
  • nondenominational: only 2_372, but it's a nice catch-all
  • latter_day_saints: 988 + latter-day_saints: 457 = only ~1_400, but I presume that mormon may eventually consolidate into one of these tags.

Checklist and Test-Documentation Template

Read on to get your PR merged faster…

Follow these steps to test your PR yourself and make it a lot easier and faster for maintainers to check and approve it.

This is how it works:

  1. After you submit your PR, the system will create a preview and comment on your PR:

    🍱 Your pull request preview is ready.
    If this is your first contribution to this project, the preview will not happen right away but requires a click from one of the project members. We will do this ASAP.

  2. Once the preview is ready, use it to test your changes.

  3. Now copy the snippet below into a new comment and fill out the blanks.

  4. Now your PR is ready to be reviewed.

## Test-Documentation

### Preview links & Sidebar Screenshots

<!-- Use the preview to find examples, select the feature in question and **copy this link here**.
     Find examples of nodes/areas. Find examples with a lot of tags or very few tags. – Whatever helps to test this thoroughly.
     Add relevant **screenshots** of the sidebar of those examples. -->

<!-- FYI: What we will check:
     - Is the [icon](https://github.com/ideditor/schema-builder/blob/main/ICONS.md) well chosen.
     - Are the fields well-structured and have good labels.
     - Do the dropdowns (etc.) work well and show helpful data. -->

### Search

<!-- **Test the search** of your preset and share relevant **screenshots** here.
     - Test the preset name as search terms.
     - Also test the preset terms and aliases as search terms (if present). -->

### Info-`i`

<!-- **Test the info-i** for your fields and preset and share relevant **screenshots** here.
     The info needs to help mappers understand the preset and when to use it.
     [Learn more…](https://github.com/openstreetmap/id-tagging-schema/blob/main/CONTRIBUTING.md#info-i)
 -->

### Wording

- [x] American English
- [x] `name`, `aliases` (if present) use Title Case
- [x] `terms` (if present) use lower case, sorted A-Z
<!-- Learn more in https://github.com/openstreetmap/id-tagging-schema/blob/main/GUIDELINES.md#2-design-the-preset -->

In the spirit of openstreetmap#2028, adds more high-use denominations
from taginfo that did not appear in a freeform search on iD.
@matkoniecz matkoniecz added the new-label changes the name, aliases or terms of a preset label Apr 9, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 9, 2026

🍱 Your pull request preview is ready

Please use this preview to check your changes. Ideally use the test documentation template and document your test results by commenting on the PR. This will speed up the review process for everyone.

FYI, once this PR is merged, you can use the iD Editor Preview to test your changes in interaction with all other changes.

@michaelblyons
Copy link
Copy Markdown
Contributor Author

screenshot of iD sidebar showing 'orthod' search including 'Christian Church' in results

Comment thread data/presets/amenity/place_of_worship/christian.json
Co-authored-by: Mateusz Konieczny <matkoniecz@gmail.com>
@matkoniecz
Copy link
Copy Markdown
Collaborator

now just waiting for others to potentially comment, but I added reminder on 2026-04-15 (or later) to merge it

@matkoniecz matkoniecz merged commit 4341eb1 into openstreetmap:main Apr 15, 2026
5 checks passed
@matkoniecz
Copy link
Copy Markdown
Collaborator

Thanks for the PR! It is now merged but note that before you will see it in iD few things need to happen.

iD tagging schema needs to get release (see https://github.com/openstreetmap/id-tagging-schema/releases - latest one mentioned there is just a draft). And later needs to be pulled in by iD.

Thanks again for your contribution! If you are interested in making other one it would be really welcome!

@matkoniecz matkoniecz changed the title Add more denominations to Christian place_of_worship Add more denominations as terms to Christian place_of_worship Apr 15, 2026
@matkoniecz matkoniecz changed the title Add more denominations as terms to Christian place_of_worship Add more denominations as search terms to Christian place_of_worship Apr 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-label changes the name, aliases or terms of a preset

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants