Set common tags for trees#455
Merged
tyrasd merged 11 commits intoopenstreetmap:mainfrom May 16, 2022
Binnette:patch-2
Merged
Conversation
Contributor
Binnette
commented
May 12, 2022
Binnette
commented
- Added important fields for trees identification: genus, species, taxon.
- Added others common fields
tordans
requested changes
May 13, 2022
Collaborator
tordans
left a comment
tordans
left a comment
There was a problem hiding this comment.
A few comments. I think we could keep this a bit simpler.
tyrasd
requested changes
May 13, 2022
Binnette
commented
May 13, 2022
Contributor
Author
Binnette
left a comment
Binnette
left a comment
There was a problem hiding this comment.
Seems good to me now 👍
tyrasd
requested changes
May 16, 2022
tyrasd
added
new-field
Contributor
Author
|
Thanks @tyrasd. I just created the missing files. Please review them 👍 |
tyrasd
approved these changes
May 16, 2022
Contributor
Author
|
Great! Thank @tyrasd! Have a nice day 🚀 |
1ec5
reviewed
May 17, 2022
1ec5
reviewed
May 19, 2022
| { | ||
| "key": "genus", | ||
| "type": "combo", | ||
| "label": "Genus", |
Contributor
There was a problem hiding this comment.
Will this field ever be used for animal species, for example in the Animal Enclosure preset? If so, Vietnamese has distinct words for botanical genera versus zoological genera, so I’ll have to include both in the field name.
Member
There was a problem hiding this comment.
Will this field ever be used for animal species
Not in the short or medium term I would say.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.