Updated natural=rock and natural=stone presets#471
Updated natural=rock and natural=stone presets#471bgo-eiu wants to merge 14 commits intoopenstreetmap:mainfrom
natural=rock and natural=stone presets#471Conversation
| { | ||
| "key": "geological", | ||
| "type": "defaultCheck", | ||
| "label": "Exposed bedrock", |
There was a problem hiding this comment.
Field names should be in Title Case.
| "erratic" | ||
| ], | ||
| "name": "Unattached Stone / Boulder" | ||
| "name": "Glacial Erratic / Boulder" |
There was a problem hiding this comment.
It’s been a long time since my geology appreciation class in school. “Glacial erratic” is a term I’ve never encountered before, despite hailing from in a region where terms like “terminal moraine” are well known. If there’s no colloquial term for this specific concept, then “Glacial Erratic” is a good name for the preset. But seeing “boulder” next to it might make me inclined to choose this obscurely named preset over “Rock” when tagging a decorative boulder. Maybe “Boulder” should be an alias but not part of the name? (“Decorative boulders”, marketed as such, are so common at garden stores that it could even be a term for that preset.)
There was a problem hiding this comment.
I was kind of on the fence since boulder is a more commonly known term. The German concept of "findling" that the tag is used for does seem to be a near exact match to "glacial erratic" though so boulder could just be an alias. Good point about decorative boulders / landscape boulders, I was thinking a lot of what people would describe as boulders count as glacial erratics anyway but those would not.
Thank you for the feedback, I will update 👍
| "moreFields": [ | ||
| "width", | ||
| "diameter", | ||
| "circumference", |
There was a problem hiding this comment.
This field is currently called “Circumference (at Breast Height)” because the natural=tree tagging scheme derives circumference from a diameter at breast height (DBH) measurement. (Go figure.) We’ll need to split out a different field for circumferences of other things, like rocks, for which “breast height” would be baffling.
/ref #455
There was a problem hiding this comment.
Didn't realize it was that specific - I think there are already petrified trees on the map as natural=rock so it's not totally out of the question but diameter will do.
|
Updated to reflect feedback above |
|
Updated to avoid duplication in terms/aliases |
| "name": "Attached Rock / Boulder" | ||
| "name": "Rock" |
There was a problem hiding this comment.
Just "Rock" for natural=rock. This is the more common tag and people have been using it for a variety of types of rocks so the simple name seems OK as long as the terms are there.
- The terms are not visible to people using the iD presets. Only
aliaseswill be, but then only if one specifically searches those - Well this would lead to
natural=rockbeing tagged (a lot) on free-standing non-attached rocks which seems to be wrong according to the previous discussion/research.
If I understand your point correctly, you are saying that this is what is happening anyway already a lot, so renaming the preset name to just "Rock" is merely following the de-facto tagging situation and not redefining the meaning of a tag. The latter, we absolutely do not want for obvious reasons that I hope do not need explaining.
What I am missing is proof for the claim that this is indeed the de-facto tagging situation and if you have proof, it should first be documented in the wiki. How much percent of natural=rock is not really a rock attached to bedrock and how much percent is on the other hand tagged correctly according to the wiki definition? Without this, we cannot simply shrug this distinction away in an iD preset PR. After all, the very first two sentences of the wiki article mention this distinction:
natural=rock describes a notable rock feature or small group of rocks, attached to the underlying bedrock, mostly used on a single node element.
On the contrary, single boulders not attached to the bedrock are better tagged as natural=stone.
... and iD (presets), too, has been denoting the meaning of natural=rock correctly according to the wiki definition since the preset had been added.
There was a problem hiding this comment.
Good point - I have a strong suspicion the de facto use is for any rock due to how the word is understood in English, but I will do some more formal queries on this for documentation first.
westnordost
left a comment
There was a problem hiding this comment.
See https://github.com/openstreetmap/id-tagging-schema/pull/471/files#r884296415
As it stands, this would change the definition of a well-documented tag.
|
Also note that the wiki definition of
So, this includes more than a glacial erratic - any boulder or rock that is not attached to the underlying terrain is a |
|
I am going to look into:
And document the findings for this. |
Co-authored-by: Martin Raifer <martin@raifer.tech>
Co-authored-by: Martin Raifer <martin@raifer.tech>
|
Great! Though, in regards to this, just a disclaimer that I am not the maintainer of the iD presets, @tyrasd is. In particular, I am not sure what happens if your finding is that indeed, many tagged |
|
Great that you're going to look into this in more detail @bgo-eiu !
In general I do abstain from modelling presets in a way that contradicts or otherwise mismatches the documentation on the wiki. If you find that the documentation on the wiki does in fact not match real-world usage of the tags, then we first need to find out why that is: If it is because of editor presets which are not conveying the intended meaning well enough, these presets should probably be improved/clarified. If it is because the tagging concept is not well enough defined or too complex for mappers, then the tagging needs to be redefined, optimally through a tagging proposal. It could also be the case that the wiki just contained some misleading information, then it would suffice to update the wiki. |
| "name" | ||
| "name", | ||
| "height", | ||
| "geological_outcrop" |
There was a problem hiding this comment.
@bgo-eiu ping?
I have not looked much into PR in general, but I plan to close it as abandoned given no reaction to comment over 3 years. Just to confirm: is it abandoned?
| { | ||
| "icon": "temaki-boulder3", | ||
| "moreFields": [ | ||
| "geological_volcanic_lava_field" |
There was a problem hiding this comment.
For the geological=volcanic_lava_field tag the combined usage with natural=bare_rock seems to be quite popular. Perhaps it could make sense to have this combination as a dedicated preset, so that it can be more easily found when mapping such features?
9d3204d to
49f529e
Compare
natural=rock and natural=stone presets
|
waiting for whether it is abandoned, see https://github.com/openstreetmap/id-tagging-schema/pull/471/changes/BASE..02aed633bb3252085518ae07feb114c2c505c0ad#r2862909126 |
These updates mostly reflect the discussion in #469 , with the objective of arriving at presets for natural=rock and natural=stone that are more clear in meaning and still relate to how they are used.
Included in this version:
"rock," "stone," and "boulder" as terms for both since enough people are using these interchangeably that it would help to see both options. Added some miscellaneous related terms for both that I found from searching ("cairns" appears to be a term that can be used to describe rocks used as trail markers for example).
"Glacial Erratic / Boulder" as the name of the natural=stone preset because as @westnordost clarified, this is being used more specifically than the name "stone" or "boulder" suggests alone. This would help make it more clear how people are using this tag.
Just "Rock" for natural=rock. This is the more common tag and people have been using it for a variety of types of rocks so the simple name seems OK as long as the terms are there.
Added "Exposed bedrock" as a checkbox field for natural=rock. Per @matkoniecz asking about this, I think that this has a much more clear meaning for adding geological=outcrop to natural=rock. Attached is too ambiguous and was confusing in the first place.
Added dimension field options (height by default; diameter, width, circumference in additional) since these are often used in combination and it would help to know what type of object people are actually mapping.
Added a "Lava field" checkbox field in the additional options for natural=bare_rock which adds geological=volcanic_lava_field. This tag combination is used a lot in Iceland for example. I noticed bare_rock didn't have very much in the presets so that could be a helpful detail to have in there.