Skip to content

Updated natural=rock and natural=stone presets #471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bgo-eiu wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Updated natural=rock and natural=stone presets #471

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
bd1d019
added geological outcrop field
bgo-eiu May 27, 2022
1c9309b
added more terms + fields for rock
bgo-eiu May 27, 2022
ca17efb
added dimension fields and more terms for stone
bgo-eiu May 27, 2022
d76ecd0
Create geological_volcanic_lava_field.json
bgo-eiu May 27, 2022
20fc9a1
added lava field field for bare rock
bgo-eiu May 27, 2022
6be7bd2
added more terms for rock + width field as option
bgo-eiu May 27, 2022
eabc7de
title case field name
bgo-eiu May 28, 2022
2a6ca1b
title case field name
bgo-eiu May 28, 2022
e2ea3ce
added decorative boulder terms based on feedback; removed circumference
bgo-eiu May 28, 2022
b5251bf
added boulder alias; removed circumference to avoid conflation w tree…
bgo-eiu May 28, 2022
209f71b
avoiding duplication of labels
bgo-eiu May 28, 2022
eb7a322
avoiding duplication of labels
bgo-eiu May 28, 2022
afcba36
add missing brace
bgo-eiu May 29, 2022
02aed63
add missing brace
bgo-eiu May 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions data/fields/geological_outcrop.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"key": "geological",
"type": "defaultCheck",
"label": "Exposed Bedrock",
"strings": {
"options": {
"undefined": "No",
Comment thread
matkoniecz marked this conversation as resolved.
"outcrop": "Yes"
}
}
}
11 changes: 11 additions & 0 deletions data/fields/geological_volcanic_lava_field.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"key": "geological",
"type": "defaultCheck",
"label": "Lava Field",
"strings": {
"options": {
"undefined": "No",
"volcanic_lava_field": "Yes"
}
}
}
3 changes: 3 additions & 0 deletions data/presets/natural/bare_rock.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
{
"icon": "temaki-boulder3",
"moreFields": [
"geological_volcanic_lava_field"
Copy link
Copy Markdown
Member

@tyrasd tyrasd May 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the geological=volcanic_lava_field tag the combined usage with natural=bare_rock seems to be quite popular. Perhaps it could make sense to have this combination as a dedicated preset, so that it can be more easily found when mapping such features?

],
"geometry": [
"area"
],
Expand Down
19 changes: 16 additions & 3 deletions data/presets/natural/rock.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,14 @@
{
"icon": "temaki-boulder2",
"fields": [
"name"
"name",
"height",
"geological_outcrop"
Copy link
Copy Markdown
Member

@tyrasd tyrasd May 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something that irritates me a bit is that the proposed added field for geological=outcrop to the natural=stone preset currently only has very few usages (only 30 map features have this tag combination). The wiki also doesn't mention this particular usage.

Copy link
Copy Markdown
Collaborator

@matkoniecz matkoniecz Feb 27, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bgo-eiu ping?

I have not looked much into PR in general, but I plan to close it as abandoned given no reaction to comment over 3 years. Just to confirm: is it abandoned?

],
"moreFields": [
"width",
"diameter",
"start_date"
],
"geometry": [
"point",
Expand All @@ -13,7 +20,13 @@
"terms": [
"boulder",
"stone",
"rock"
"attached rock",
"cairn",
"bedrock",
"outcrop",
"exposed rock",
"decorative boulder",
"landscape boulder"
],
"name": "Attached Rock / Boulder"
"name": "Rock"
Comment on lines -21 to +31
Copy link
Copy Markdown
Contributor

@westnordost westnordost May 29, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just "Rock" for natural=rock. This is the more common tag and people have been using it for a variety of types of rocks so the simple name seems OK as long as the terms are there.

  1. The terms are not visible to people using the iD presets. Only aliases will be, but then only if one specifically searches those
  2. Well this would lead to natural=rock being tagged (a lot) on free-standing non-attached rocks which seems to be wrong according to the previous discussion/research.

If I understand your point correctly, you are saying that this is what is happening anyway already a lot, so renaming the preset name to just "Rock" is merely following the de-facto tagging situation and not redefining the meaning of a tag. The latter, we absolutely do not want for obvious reasons that I hope do not need explaining.

What I am missing is proof for the claim that this is indeed the de-facto tagging situation and if you have proof, it should first be documented in the wiki. How much percent of natural=rock is not really a rock attached to bedrock and how much percent is on the other hand tagged correctly according to the wiki definition? Without this, we cannot simply shrug this distinction away in an iD preset PR. After all, the very first two sentences of the wiki article mention this distinction:

natural=rock describes a notable rock feature or small group of rocks, attached to the underlying bedrock, mostly used on a single node element.

On the contrary, single boulders not attached to the bedrock are better tagged as natural=stone.

... and iD (presets), too, has been denoting the meaning of natural=rock correctly according to the wiki definition since the preset had been added.

Copy link
Copy Markdown
Author

@bgo-eiu bgo-eiu May 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point - I have a strong suspicion the de facto use is for any rock due to how the word is understood in English, but I will do some more formal queries on this for documentation first.

}
17 changes: 13 additions & 4 deletions data/presets/natural/stone.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,12 @@
{
"icon": "temaki-boulder1",
"fields": [
"name"
"name",
"height"
],
"moreFields": [
"width",
"diameter"
],
"geometry": [
"point",
Expand All @@ -11,9 +16,13 @@
"natural": "stone"
},
"terms": [
"boulder",
"stone",
"rock"
"rock",
"findling",
"erratic"
],
"aliases": [
"Boulder"
],
"name": "Unattached Stone / Boulder"
"name": "Glacial Erratic"
}
⚡