Skip to content

Add field for operator:wikidata#769

Closed
kjonosm wants to merge 1 commit intoopenstreetmap:mainfrom
kjonosm:patch-19
Closed

Add field for operator:wikidata#769
kjonosm wants to merge 1 commit intoopenstreetmap:mainfrom
kjonosm:patch-19

Conversation

@kjonosm
Copy link
Copy Markdown
Contributor

@kjonosm kjonosm commented Jan 31, 2023

See #168

@kjonosm kjonosm changed the title Create wikidata.json Add field for operaator:wikidata Jan 31, 2023
@kjonosm kjonosm changed the title Add field for operaator:wikidata Add field for operator:wikidata Jan 31, 2023
@tyrasd tyrasd added the new-field create a new field (see add-field for cases where field from presets is added to new entries) label Feb 1, 2023
@tyrasd tyrasd marked this pull request as draft February 1, 2023 10:43
@tyrasd tyrasd added the waitfor-info something is unclear with the suggestion, more information is needed to evaluate this feature reques label Feb 1, 2023
@tyrasd
Copy link
Copy Markdown
Member

tyrasd commented Feb 1, 2023

This PR only defines the field, but does not add it to any preset. Without adding it to any preset, the field would be essentially useless.

Did you intend to add this field to any preset which includes the operator field? That would have the major downside of being a lot of effort to change, as it involves changing hundreds of presets. I think we should think about a better solution, e.g. involving an improved "wikidata" field which can directly work on a tag-triplet, e.g. here operator + operator:wikidata + operator:wikipedia. That would require some changes to the schema, however.

@kjonosm
Copy link
Copy Markdown
Contributor Author

kjonosm commented Feb 1, 2023

Did you intend to add this field to any preset which includes the operator field?

@tyrasd: That was the idea following the already featured subject:wikidata field. However, not to all presets with operator=* info but only those where operator:wikidata=* is commonly used, see NSI for reference. If you don't consider merging this pull request (and others adding *:wikidata fields) please let me know and I am happy to delete them.

@matkoniecz
Copy link
Copy Markdown
Collaborator

matkoniecz commented Feb 5, 2023

Without adding it to any preset, the field would be essentially useless.

What about objects where this tag was already added?

@kjonosm
Copy link
Copy Markdown
Contributor Author

kjonosm commented Feb 12, 2023

What about objects where this tag was already added?

The field still needs to be added to the respective presets...

@matkoniecz
Copy link
Copy Markdown
Collaborator

@kjonosm Do you plan to fix technical issue that was mentioned in comment above?

@kjonosm
Copy link
Copy Markdown
Contributor Author

kjonosm commented Jun 16, 2025

@matkoniecz

Do you plan to fix technical issue that was mentioned in comment above?

That depends on the decision of @tyrasd regarding the above mentioned "better solution".

Improving the wikidata field within the schema builder is unfortunately beyond my skills.

But if people are okay to adding the field to existing specific presets I am happy to update some presets where I consider it useful.

@matkoniecz
Copy link
Copy Markdown
Collaborator

But if people are okay to adding the field to existing specific presets I am happy to update some presets where I consider it useful.

given that changes to schema are stalled and beyond your abilities anyway (and also mine, at least right now - maybe I could spend time to learn what ideditor/schema-builder repo is doing)...

I guess I would try probing PR adding it to just some presets (maybe low number like 10 or 30?) to see whether it will get accepted? At least I would do this if I would be making such PR.

@matkoniecz matkoniecz closed this Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-field create a new field (see add-field for cases where field from presets is added to new entries) waitfor-info something is unclear with the suggestion, more information is needed to evaluate this feature reques

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants