Skip to content

Create unsearchable preset for associatedStreet#997

Merged
tyrasd merged 1 commit intoopenstreetmap:mainfrom
serhii-muchychka:associated-street
Oct 21, 2025
Merged

Create unsearchable preset for associatedStreet#997
tyrasd merged 1 commit intoopenstreetmap:mainfrom
serhii-muchychka:associated-street

Conversation

@serhii-muchychka
Copy link
Copy Markdown
Contributor

@Cyrille37

This comment was marked as outdated.

@matkoniecz

This comment was marked as resolved.

@matkoniecz matkoniecz closed this Sep 4, 2025
@matkoniecz matkoniecz reopened this Sep 4, 2025
@matkoniecz

This comment was marked as resolved.

@matkoniecz

This comment was marked as resolved.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 8, 2025

🍱 Your pull request preview is ready

Please use this preview to check your changes. Ideally use the test documentation template and document your test results by commenting on the PR. This will speed up the review process for everyone.

FYI, once this PR is merged, you can use the iD Editor Preview to test your changes in interaction with all other changes.

@tordans
Copy link
Copy Markdown
Collaborator

tordans commented Sep 8, 2025

After we merge this, we need to ping #1538 because AFAIK this will need to be updated to add the new relation.

@matkoniecz
Copy link
Copy Markdown
Collaborator

tested https://pr-997--ideditor-presets-preview.netlify.app/id/dist/#locale=en&map=19.07/49.35525/19.60342&disable_features=boundaries&background=MAPNIK&id=r2172790 and it seems to work

screen-2025-09-09-11-36-08

without that PR:

screen-2025-09-09-11-36-48

PS I want to register my deep, deep dislike toward associatedStreet schema and expecting mappers to do manually what computers can do on their own and complicating tagging schema without good reason. I eradicated those in my area, with community agreement.

@tordans tordans added the waiting-ready-to-merge Ready to merge, but let's wait a few days for possible feedback. label Sep 9, 2025
@tordans
Copy link
Copy Markdown
Collaborator

tordans commented Sep 9, 2025

Thanks for testing it @matkoniecz. Technically it looks good.

I just noticed, that the reason for this PR was resolved 3 weeks ago with an exception in iD openstreetmap/iD#9639 (comment)

So I would like to wait for other input on this before merging.

Because as a data consumer I agree, that this tagging is problematic.

@tordans tordans added the waitfor-discussion a discussion in the osm community (e.g. a tag proposal) is required before this can be worked on label Sep 9, 2025
@matkoniecz
Copy link
Copy Markdown
Collaborator

Note that preset is unsearchable so it should not result in people being encouraged to use that terrible idea.

And for example French community is using it anyway.

@matkoniecz
Copy link
Copy Markdown
Collaborator

@tordans How long we should wait? What you would propose as enough? Week?

@tyrasd tyrasd removed waiting-ready-to-merge Ready to merge, but let's wait a few days for possible feedback. waitfor-discussion a discussion in the osm community (e.g. a tag proposal) is required before this can be worked on labels Oct 21, 2025
@tyrasd tyrasd merged commit efceefd into openstreetmap:main Oct 21, 2025
5 checks passed
@serhii-muchychka serhii-muchychka deleted the associated-street branch October 24, 2025 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

iD silently changes the relation type associatedStreet->associatedstreet

5 participants