Incorrect Resize Behavior for Pasted Chips#127
Open
ihordubas99 wants to merge 4 commits intodevfrom
Open
Conversation
Co-authored-by: Copilot <copilot@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
https://community.openproject.org/projects/communicator-stream/work_packages/74190
What are you trying to accomplish?
Fix incorrect resize behavior for pasted inline work package chips.When a chip was copied and pasted,
BlockNote duplicated all props verbatim - including instanceId. Since wpBridge routes resize/delete actions by instanceId, two chips with the same ID caused every action to always affect the first chip in the document, not the intended one.
What approach did you choose and why?
Registered a ProseMirror transformPasted plugin (pasteDeduplicatePlugin) that intercepts pasted content before it enters the document and regenerates instanceId for every inline WP chip found in the slice.
Also updated the host application (OpBlockNoteEditor) to call useDeduplicateInstanceIds: opf/openproject#22969
This is the correct hook for this problem - it prevents the duplicate from ever existing rather than cleaning it up after the fact. The plugin is registered via _tiptapEditor.registerPlugin(), following the same pattern already established in BlockWorkPackageComponent for selectionUpdate.
Alternative considered: an onChange listener that scans for duplicate instanceId values and patches them post-insert. Discarded because it runs on every editor change, has a window where the document is in an inconsistent state, and requires a guard to prevent infinite loops from its own updateBlock calls.
Merge checklist