Skip to content

Incorrect Resize Behavior for Pasted Chips#127

Open
ihordubas99 wants to merge 4 commits intodevfrom
bug/74190-incorrect-resize-behavior-for-pasted-chips
Open

Incorrect Resize Behavior for Pasted Chips#127
ihordubas99 wants to merge 4 commits intodevfrom
bug/74190-incorrect-resize-behavior-for-pasted-chips

Conversation

@ihordubas99
Copy link
Copy Markdown
Collaborator

@ihordubas99 ihordubas99 commented Apr 28, 2026

Ticket

https://community.openproject.org/projects/communicator-stream/work_packages/74190

What are you trying to accomplish?

Fix incorrect resize behavior for pasted inline work package chips.When a chip was copied and pasted,

BlockNote duplicated all props verbatim - including instanceId. Since wpBridge routes resize/delete actions by instanceId, two chips with the same ID caused every action to always affect the first chip in the document, not the intended one.

What approach did you choose and why?

Registered a ProseMirror transformPasted plugin (pasteDeduplicatePlugin) that intercepts pasted content before it enters the document and regenerates instanceId for every inline WP chip found in the slice.

Also updated the host application (OpBlockNoteEditor) to call useDeduplicateInstanceIds: opf/openproject#22969

This is the correct hook for this problem - it prevents the duplicate from ever existing rather than cleaning it up after the fact. The plugin is registered via _tiptapEditor.registerPlugin(), following the same pattern already established in BlockWorkPackageComponent for selectionUpdate.

Alternative considered: an onChange listener that scans for duplicate instanceId values and patches them post-insert. Discarded because it runs on every editor change, has a window where the document is in an inconsistent state, and requires a guard to prevent infinite loops from its own updateBlock calls.

Merge checklist

  • Added/updated tests
  • Added/updated documentation in Lookbook (patterns, previews, etc)
  • Tested major browsers (Chrome, Firefox, Edge, ...)

@ihordubas99 ihordubas99 self-assigned this Apr 28, 2026
@ihordubas99 ihordubas99 changed the title fix: regenerate instanceId on paste to prevent resize targeting wrong… Incorrect Resize Behavior for Pasted Chips Apr 28, 2026
@ihordubas99 ihordubas99 marked this pull request as ready for review April 28, 2026 11:21
@ihordubas99 ihordubas99 requested a review from judithroth April 28, 2026 11:22
@ihordubas99 ihordubas99 marked this pull request as draft April 28, 2026 11:24
@ihordubas99 ihordubas99 marked this pull request as ready for review April 28, 2026 11:39
Co-authored-by: Copilot <copilot@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant