Incorrect Resize Behavior for Pasted Chips#22969
Open
ihordubas99 wants to merge 1 commit intofeature/73664-extend-documents-links-block-level-elementsfrom
Open
Conversation
|
Caution The provided work package version does not match the core version Details:
Please make sure that:
|
3 tasks
ihordubas99
commented
Apr 29, 2026
| const editor = useCreateBlockNote(editorParams, [activeUser]); | ||
|
|
||
| useInlineWpEvents(editor); | ||
| useDeduplicateInstanceIds(editor); |
Collaborator
Author
There was a problem hiding this comment.
I wonder if it might be better to import and call useDeduplicateInstanceIds directly inside useInlineWpEvents (within op-blocknote-extensions) instead of adding it separately in OpBlockNoteEditor.
This way we could avoid accumulating multiple hook imports in the host application and keep related logic encapsulated in one place.
Just a thought - it might help keep things cleaner and easier to maintain going forward
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
https://community.openproject.org/projects/communicator-stream/work_packages/74190
What are you trying to accomplish?
Register
useDeduplicateInstanceIdsinOpBlockNoteEditoralongside the existinguseInlineWpEvents.This is required for the fix introduced in the
op-blocknote-extensionsPR - without calling the hook in the host application, pasted chips will still receive duplicateinstanceIdvalues and resize/delete actions will continue to target the wrong chip.What approach did you choose and why?
Two-line change: added
useDeduplicateInstanceIdsto the import fromop-blocknote-extensionsand called it afteruseInlineWpEventsinOpBlockNoteEditor.Merge checklist