Fix documentation for polyhedral_fan to give the correct argument order#5917
Merged
benlorenz merged 1 commit intooscar-system:masterfrom Apr 8, 2026
Merged
Fix documentation for polyhedral_fan to give the correct argument order#5917benlorenz merged 1 commit intooscar-system:masterfrom
polyhedral_fan to give the correct argument order#5917benlorenz merged 1 commit intooscar-system:masterfrom
Conversation
imkhln
changed the title
polyhedral_fan
imkhln
changed the title
polyhedral_fanpolyhedral_fan
benlorenz
added
documentation
benlorenz
approved these changes
Apr 2, 2026
benlorenz
pushed a commit
that referenced
this pull request
Apr 8, 2026
(cherry picked from commit fc99db7)
Merged
benlorenz
changed the title
polyhedral_fan polyhedral_fan
fingolfin
changed the title
polyhedral_fanpolyhedral_fan to give the correct argument order
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #5828. I didn't adjust the phrase "Assemble a polyhedral fan from ray generators, lineality generators, and an
IncidenceMatrixindicating which rays form a cone" because, ultimately, this is the natural way of phrasing it, even if the order of arguments is different.