Merged
Conversation
Ensure the parent ring of the generators in the returned ideal is the same as the base ring of the ideal after an f4 eliminate (cherry picked from commit 9f41c65)
14c9a78 to
7842f64
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fitting_idealto always return an ideal, even if it is the ideal generate by1(where sometimes the ring was returned instead) #5903polyhedral_fanto give the correct argument order #5917groebner_basis_f4when used witheliminate > 0#5918x-ref: #5919