fix(sourcemaps): Handle null mappings properly#2149
Merged
Conversation
DeMoorJasper
changed the title
devongovett
previously approved these changes
Jan 5, 2019
devongovett
reviewed
Jan 5, 2019
| const fs = require('@parcel/fs'); | ||
| const path = require('path'); | ||
| const mapValidator = require('sourcemap-validator'); | ||
| const SourceMap = require('../src/SourceMap'); |
Member
There was a problem hiding this comment.
Looks like the tests are failing because of this import. Maybe this test should be inside the parcel-bundler package rather than the integration tests?
Member
Author
There was a problem hiding this comment.
It probably should although maybe it would be a good idea to extract the sourcemap implementation into it's own package, for use in plugins and integration tests?
Member
|
seems like some html minification tests are failing? doesn't seem related though |
devongovett
approved these changes
Jan 7, 2019
wbinnssmith
pushed a commit
that referenced
this pull request
Mar 13, 2019
wbinnssmith
pushed a commit
that referenced
this pull request
Mar 14, 2019
wbinnssmith
pushed a commit
that referenced
this pull request
Mar 14, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
↪️ Pull Request
This allows null mappings in parcels sourcemaps.
Creating more accurate sourcemaps.
Also adds a couple extra tests for sourcemaps, using the SourceMap class directly, giving a more in depth coverage of SourceMap
Closes #1825
Original PR: #1851
💻 Examples
🚨 Test instructions
Run unit tests
✔️ PR Todo