Conversation
Removes ESLint 5.x with Airbnb style guide and adds Biome with recommended rules. Formatter is disabled; JSON linting is disabled. ESLint config files are deleted. Code fixes for Biome rule violations will follow in a separate commit. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Applied safe fixes (arrow functions, node: protocol prefixes) via `biome lint --write --unsafe`, then manually converted forEach calls to for...of loops to satisfy the noForEach rule. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR replaces ESLint (Airbnb base + plugins) with Biome as the repository linter, updates linting configuration, and applies code edits to satisfy the new lint rules across tests and scripts.
Changes:
- Swap
eslint-based linting forbiome lintand addbiome.jsonconfiguration. - Update various JS files (tests and scripts) to match Biome’s recommended rules (e.g.,
node:core imports, arrow callbacks /for...of). - Adjust CI Node matrix and workflow triggers.
Reviewed changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
package.json |
Replaces eslint lint script/deps with Biome. |
package-lock.json |
Updates lockfile to remove ESLint deps and add Biome + platform CLIs. |
biome.json |
Adds Biome configuration (recommended lint rules, formatter disabled). |
.eslintrc.json |
Removes root ESLint configuration. |
test/.eslintrc.json |
Removes test-only ESLint overrides. |
test/test_phyx2ontology.js |
Updates Node core imports and Mocha callbacks for linting compatibility. |
test/test_phyx.js |
Refactors iteration/callback style for linting compatibility. |
test/regnum2phyx/exec.js |
Refactors iteration/callback style for linting compatibility. |
regnum2phyx/regnum2phyx.js |
Refactors loops/imports; adjusts citation field handling. |
phyx2ontology/phyx2ontology.js |
Refactors loops/imports and replaces inner-callback returns with continue. |
.github/workflows/test.yaml |
Updates Node matrix and modifies workflow triggers. |
Comments suppressed due to low confidence (1)
test/test_phyx.js:104
assert.true(result)is not part of Chai’sassertAPI (the usual assertion isassert.isTrue(result)/assert.strictEqual(result, true)). This is currently inside a skipped test, but it will fail immediately if the.skipis removed as the comment suggests.
const result = phyxSchema(json);
const errorStrings = (phyxSchema.errors || []).map(err => ajvInstance.errorsText([err]));
assert.deepEqual(errorStrings, []);
assert.isNull(phyxSchema.errors);
assert.true(result);
});
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Draft
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
hlapp
approved these changes
Mar 4, 2026
Member
hlapp
left a comment
There was a problem hiding this comment.
Haven't taken a deep look, but apparently Copilot did, and those comments got addressed. I'm not seeing anything else jump out at me, so 👍🏻
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Used Claude to replace ESLint (with Airbnb base style) with Biome because the Airbnb base style does not appear to be maintained. This will bring this repo in line with phyx.js (phyloref/phyx.js#156).
Also removed the
pushtrigger in GitHub Actions -- thepull_requesttrigger covers all of our use cases.