Conversation
Temporarily turned off lint/formatting on test files.
gaurav
force-pushed
the
replace-eslint-with-biome
branch
2 times, most recently
from
55db110 to
325df29
Compare
Merged
Merged
hlapp
approved these changes
Feb 25, 2026
Member
hlapp
left a comment
hlapp
left a comment
There was a problem hiding this comment.
I agree with the replacement idea, the style changes look reasonable (even if inflating loc count?) and looks like everything passes 👍
gaurav
added a commit
to phyloref/clade-ontology
that referenced
this pull request
Mar 17, 2026
Used Claude to replace ESLint (with Airbnb base style) with Biome because the Airbnb base style does not appear to be maintained. This will bring this repo in line with phyx.js (phyloref/phyx.js#156). Also removed the `push` trigger in GitHub Actions -- the `pull_request` trigger covers all of our use cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces ESLint with Biome. We previously used ESLint with the Airbnb style, which applied a bunch of rules for us, but since package
eslint-config-airbnb-basehasn't been updated in four years and prevents us upgrading to a more recent version of ESLint (see e.g. #154). We could stick with ESLint and come up with a custom configuration ourselves, but that seems like a lot of work.Instead, I think we should replace ESLint with Biome, a parser and linter written in Rust that is really fast and has very sensible recommendations. This PR includes:
.eslintignore,.eslintrc.json) and configuration from package.json.biome.json) to make it a bit more similar to our existing code.