Skip to content

stmt reference: update sql_calc_found_rows#3946

Merged
TomShawn merged 1 commit intomasterfrom
unknown repository
Sep 23, 2020
Merged

stmt reference: update sql_calc_found_rows#3946
TomShawn merged 1 commit intomasterfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Sep 21, 2020

What is changed, added or deleted? (Required)

This PR updates a docs case for pingcap/tidb#19506 that was missed earlier.

This only applies to master.

I fixed another case of inconsistent formatting that is unrelated.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Have version specific changes
  • Might cause conflicts

@ghost ghost added v5.0 This PR/issue applies to TiDB v5.0. status/PTAL This PR is ready for reviewing. labels Sep 21, 2020
@TomShawn TomShawn requested a review from jackysp September 23, 2020 02:44
Copy link
Copy Markdown
Contributor

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 23, 2020
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Sep 23, 2020

@nullnotnil The v5.0 label is only for the features or changes planned for the upcoming v5.0 release. I am not sure whether this change is v5.0-related or just applicable to the master branch.

@TomShawn TomShawn self-assigned this Sep 23, 2020
@TomShawn TomShawn added size/small Changes of a small size. translation/doing This PR's assignee is translating this PR. and removed status/PTAL This PR is ready for reviewing. labels Sep 23, 2020
@ghost
Copy link
Copy Markdown
Author

ghost commented Sep 23, 2020

@nullnotnil The v5.0 label is only for the features or changes planned for the upcoming v5.0 release. I am not sure whether this change is v5.0-related or just applicable to the master branch.

I linked the tidb PR which is related to the change. You can see from here that it does not have any cherry-picks, and thus applies to v5.0 only :-)

@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Sep 23, 2020

@nullnotnil The v5.0 label is only for the features or changes planned for the upcoming v5.0 release. I am not sure whether this change is v5.0-related or just applicable to the master branch.

I linked the tidb PR which is related to the change. You can see from here that it does not have any cherry-picks, and thus applies to v5.0 only :-)

Looks like it is just applicable to the master branch and not v5.0-related (a list of features planned by PM). I'll remove the label in this PR.

@TomShawn TomShawn removed the v5.0 This PR/issue applies to TiDB v5.0. label Sep 23, 2020
Copy link
Copy Markdown
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Sep 23, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Sep 23, 2020
@TomShawn TomShawn merged commit 622a729 into pingcap:master Sep 23, 2020
@TomShawn TomShawn added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR's assignee is translating this PR. labels Oct 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/small Changes of a small size. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants