planner: disable SQL_CALC_FOUND_ROWS/LOCK IN SHARE MODE by default#19506
Conversation
ghost
requested review from
hanfei1991,
wshwsh12 and
zz-jason
and removed request for
a team
Author
|
I noticed after I wrote this, that I could also implement this in |
ghost
mentioned this pull request
ghost
changed the title
Author
|
I have updated this PR to fix |
Author
|
/run-all-tests |
Author
|
/run-unit-test |
This was referenced Sep 10, 2020
Author
|
/run-all-tests tidb-test=pr/1087 |
Author
|
/run-all-tests tidb-test=pr/1087 |
Author
|
/run-integration-ddl-test tidb-test=pr/1087 |
1 similar comment
Author
|
/run-integration-ddl-test tidb-test=pr/1087 |
Author
|
/run-unit-test tidb-test=pr/1087 |
1 similar comment
Author
|
/run-unit-test tidb-test=pr/1087 |
Author
|
/run-integration-ddl-test tidb-test=pr/1087 |
Author
|
/run-unit-test |
Author
Thanks! Should be fixed now. |
Contributor
|
/merge |
Contributor
|
/run-all-tests |
Contributor
|
@nullnotnil merge failed. |
Contributor
|
/merge |
Contributor
|
/run-all-tests |
ghost
mentioned this pull request
ghost
mentioned this pull request
9 tasks
9 tasks
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Nov 12, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
Contributor
|
cherry pick to release-4.0 in PR #21005 |
ti-srebot
added a commit
that referenced
this pull request
Nov 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: Fixes #14448 but leaves #8235 open to (eventually) add the functionality
Also fixes #19383
Problem Summary:
Unless you are reading every page of the TiDB manual, you may not notice that a query using
SQL_CALC_FOUND_ROWSwill return wrong results without a warning or error. This is unsafe, as described why in #14448.Similarly,
SELECT LOCK IN SHARE MODEis also described in the manual as a noop. But that's not obvious to new users.This protects against incorrect usage via the enable_noop_functions flag; meaning that applications that want to execute the query and receive broken results have a way out.
What is changed and how it works?
What's Changed:
Queries using SQL_CALC_FOUND_ROWS or LOCK IN SHARE MODE now get an error by default.
Related changes
Docs PR pingcap/docs#3898
Check List
Tests
Side effects
Release note
SQL_CALC_FOUND_ROWSorLOCK IN SHARE MODE. This helps alert users that this feature is not implemented by TiDB, but a workaround to restore the previous behavior is available by settingtidb_enable_noop_functions=1.