Skip to content

system-variables: update noop functions#4588

Merged
ti-srebot merged 12 commits intopingcap:masterfrom
Joyinqin:update-noop-functions
Sep 27, 2020
Merged

system-variables: update noop functions#4588
ti-srebot merged 12 commits intopingcap:masterfrom
Joyinqin:update-noop-functions

Conversation

@Joyinqin
Copy link
Copy Markdown
Contributor

@Joyinqin Joyinqin commented Sep 24, 2020

What is changed, added or deleted? (Required)

This is the PR for pingcap/tidb#19506

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Have version specific changes
  • Might cause conflicts

@Joyinqin Joyinqin marked this pull request as draft September 24, 2020 09:26
@Joyinqin
Copy link
Copy Markdown
Contributor Author

Joyinqin commented Sep 24, 2020

/cc jackysp, TomShawn

@Joyinqin
Copy link
Copy Markdown
Contributor Author

Joyinqin commented Sep 24, 2020

/label size/small, translation/from-docs

@Joyinqin Joyinqin marked this pull request as ready for review September 24, 2020 10:41
@ti-srebot ti-srebot added size/small Changes of a small size. translation/from-docs This PR is translated from a PR in pingcap/docs. labels Sep 24, 2020
jackysp
jackysp reviewed Sep 24, 2020
View reviewed changes
Comment thread system-variables.md Outdated
jackysp
jackysp reviewed Sep 25, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 25, 2020
TomShawn
TomShawn reviewed Sep 25, 2020
View reviewed changes
Comment thread system-variables.md Outdated
TomShawn
TomShawn reviewed Sep 25, 2020
View reviewed changes
Comment thread system-variables.md Outdated
TomShawn
TomShawn reviewed Sep 25, 2020
View reviewed changes
Comment thread system-variables.md Outdated
@Joyinqin @TomShawn
Apply suggestions from code review
4e3428a 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
TomShawn
TomShawn reviewed Sep 25, 2020
View reviewed changes
Comment thread system-variables.md Outdated
TomShawn and others added 2 commits September 25, 2020 17:41
@TomShawn
Update system-variables.md
dcc07b9
@Joyinqin @TomShawn
Apply suggestions from code review
bf084cd 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
TomShawn
TomShawn approved these changes Sep 27, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 27, 2020
@TomShawn TomShawn added the status/can-merge Indicates a PR has been approved by a committer. label Sep 27, 2020
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Sep 27, 2020

/run-all-tests

@ti-srebot ti-srebot merged commit 07c8083 into pingcap:master Sep 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jackysp jackysp jackysp left review comments

@ti-srebot ti-srebot ti-srebot approved these changes

+1 more reviewer

@TomShawn TomShawn TomShawn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size/small Changes of a small size. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs This PR is translated from a PR in pingcap/docs.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Joyinqin @ti-srebot @jackysp @TomShawn
⚡