system-variables: update noop functions#3898
Merged
Conversation
ghost
mentioned this pull request
TomShawn
added
needs-cherry-pick-4.0
size/small
Contributor
|
@nullnotnil Should release-4.0 be updated as well? |
Author
I have not tagged the TiDB PR for cherry-pick. But I am open to it if users request it, and will update docs accordingly. |
ti-srebot
added
status/LGT2
ti-srebot
approved these changes
Sep 14, 2020
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Contributor
|
@jackysp, @TomShawn, @ti-srebot, PTAL. |
1 similar comment
Contributor
|
@jackysp, @TomShawn, @ti-srebot, PTAL. |
Contributor
|
@TomShawn could you remove the label 'DNM'? |
Contributor
Done. Should this PR be merged after pingcap/tidb#19506? |
Contributor
Finally, it's merged. |
TomShawn
reviewed
Sep 18, 2020
ghost
deleted the
Contributor
|
/label translation/done |
ti-srebot
added
the
translation/done
Contributor
|
/unlabel translation/doing |
ti-srebot
removed
the
translation/doing
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is changed, added or deleted? (Required)
This is the PR for pingcap/tidb#19506
It can be reviewed now, but should merge after the TiDB PR.
Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?