Skip to content

store: use uniform log format for store package (#9664)#10018

Merged
jackysp merged 5 commits intopingcap:release-2.1from
jackysp:store_log_2.1
Apr 3, 2019
Merged

store: use uniform log format for store package (#9664)#10018
jackysp merged 5 commits intopingcap:release-2.1from
jackysp:store_log_2.1

Conversation

@jackysp
Copy link
Copy Markdown
Contributor

@jackysp jackysp commented Apr 3, 2019

What problem does this PR solve?

Cherry-pick #9664 to release 2.1.

Comment thread store/store.go Outdated
@@ -0,0 +1,73 @@
// Copyright 2018 PingCAP, Inc.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/2018/2019?

Comment thread store/tikv/2pc.go Outdated
log.Infof("[BIG_TXN] con:%d table id:%d size:%d, keys:%d, puts:%d, dels:%d, locks:%d, startTS:%d",
connID, tableID, size, len(keys), putCnt, delCnt, lockCnt, txn.startTS)
logutil.Logger(context.Background()).Info("[BIG_TXN]",
zap.Uint64("con", connID),
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/con/conn

Comment thread store/store.go Outdated
// boltdb:///absolute/path
//
// The engine should be registered before creating storage.
func New(path string) (kv.Storage, error) {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we use it?

@jackysp
Copy link
Copy Markdown
Contributor Author

jackysp commented Apr 3, 2019

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@jackysp jackysp requested review from lysu and tiancaiamao April 3, 2019 10:18
@jackysp
Copy link
Copy Markdown
Contributor Author

jackysp commented Apr 3, 2019

PTAL @zimulala

Copy link
Copy Markdown
Contributor

@lysu lysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp jackysp merged commit 9b4940b into pingcap:release-2.1 Apr 3, 2019
@jackysp jackysp deleted the store_log_2.1 branch April 4, 2019 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants