store: use uniform log format for store package#9664
Merged
jackysp merged 11 commits intopingcap:masterfrom Mar 22, 2019
Merged
store: use uniform log format for store package#9664jackysp merged 11 commits intopingcap:masterfrom
jackysp merged 11 commits intopingcap:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9664 +/- ##
================================================
- Coverage 67.4149% 67.3268% -0.0882%
================================================
Files 383 383
Lines 80135 80335 +200
================================================
+ Hits 54023 54087 +64
- Misses 21285 21409 +124
- Partials 4827 4839 +12 |
Contributor
Author
|
/run-all-tests |
XuHuaiyu
reviewed
Mar 15, 2019
| zap.Uint64("con", c.connID), | ||
| zap.String("action type", action.String()), | ||
| zap.Error(e), | ||
| zap.Uint64("start ts", c.startTS)) |
zimulala
reviewed
Mar 18, 2019
Contributor
Author
|
PTAL @XuHuaiyu |
XuHuaiyu
reviewed
Mar 22, 2019
| } | ||
| if err != nil { | ||
| log.Error("Unmarshal fail:", errors.Trace(err)) | ||
| logutil.Logger(context.Background()).Error("Unmarshal fail", zap.Error(err)) |
Contributor
Author
|
PTAL @XuHuaiyu |
jackysp
added a commit
to jackysp/tidb
that referenced
this pull request
Apr 3, 2019
jackysp
added a commit
that referenced
this pull request
Apr 3, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Use uniform log format for store package.
Check List
Tests
Code changes
Related changes